linux-kernel - [PATCH] fuse: remove duplicate check for nodeid

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20221213115147.26629-1-zyfjeff@linux.alibaba.com>
Date:   Tue, 13 Dec 2022 19:51:47 +0800
From:   zyfjeff <zyfjeff@...ux.alibaba.com>
To:     linux-fsdevel@...r.kernel.org, fuse-devel@...ts.sourceforge.net
Cc:     miklos@...redi.hu, linux-kernel@...r.kernel.org,
        zyfjeff <zyfjeff@...ux.alibaba.com>
Subject: [PATCH] fuse: remove duplicate check for nodeid

before this check, the nodeid has already been checked once, so
the check here doesn't make an sense, so remove the check for
nodeid here.

            if (err || !outarg->nodeid)
                    goto out_put_forget;

            err = -EIO;
    >>>     if (!outarg->nodeid)
                    goto out_put_forget;

Signed-off-by: zyfjeff <zyfjeff@...ux.alibaba.com>
---
 fs/fuse/dir.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/fs/fuse/dir.c b/fs/fuse/dir.c
index cd1a071b625a..a33cd1131640 100644
--- a/fs/fuse/dir.c
+++ b/fs/fuse/dir.c
@@ -395,8 +395,6 @@ int fuse_lookup_name(struct super_block *sb, u64 nodeid, const struct qstr *name
 		goto out_put_forget;
 
 	err = -EIO;
-	if (!outarg->nodeid)
-		goto out_put_forget;
 	if (fuse_invalid_attr(&outarg->attr))
 		goto out_put_forget;
 
-- 
2.34.0