linux-kernel - Re: [PATCH v4 0/2] ceph: fix the use-after-free bug for file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f71ab29339c88eb2cfa8f7294d03777d7a227907.camel@kernel.org>
Date:   Tue, 13 Dec 2022 07:47:03 -0500
From:   Jeff Layton <jlayton@...nel.org>
To:     xiubli@...hat.com, idryomov@...il.com, ceph-devel@...r.kernel.org
Cc:     mchangir@...hat.com, lhenriques@...e.de, viro@...iv.linux.org.uk,
        linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org
Subject: Re: [PATCH v4 0/2] ceph: fix the use-after-free bug for file_lock

On Tue, 2022-12-13 at 20:11 +0800, xiubli@...hat.com wrote:
> From: Xiubo Li <xiubli@...hat.com>
> 
> Changed in V4:
> - repeat the afs in fs.h instead of adding ceph specific header file
> 
> Changed in V3:
> - switched to vfs_inode_has_locks() helper to fix another ceph file lock
> bug, thanks Jeff!
> - this patch series is based on Jeff's previous VFS lock patch:
>   https://patchwork.kernel.org/project/ceph-devel/list/?series=695950
> 
> Changed in V2:
> - switch to file_lock.fl_u to fix the race bug
> - and the most code will be in the ceph layer
> 
> Xiubo Li (2):
>   ceph: switch to vfs_inode_has_locks() to fix file lock bug
>   ceph: add ceph specific member support for file_lock
> 
>  fs/ceph/caps.c     |  2 +-
>  fs/ceph/locks.c    | 24 ++++++++++++++++++------
>  fs/ceph/super.h    |  1 -
>  include/linux/fs.h |  3 +++
>  4 files changed, 22 insertions(+), 8 deletions(-)
> 

Both patches look good to me. You can add:

Reviewed-by: Jeff Layton <jlayton@...nel.org>