linux-kernel - Re: [PATCH] iommu: Allow .iotlb_sync_map to fail and handle s390's -ENOMEM return

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <74be1d4fff25840b8be2b786263c37840e5cca4c.camel@linux.ibm.com>
Date:   Tue, 13 Dec 2022 14:24:37 +0100
From:   Niklas Schnelle <schnelle@...ux.ibm.com>
To:     Jason Gunthorpe <jgg@...dia.com>
Cc:     Matthew Rosato <mjrosato@...ux.ibm.com>, iommu@...ts.linux.dev,
        Joerg Roedel <joro@...tes.org>,
        Pierre Morel <pmorel@...ux.ibm.com>,
        linux-s390@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        borntraeger@...ux.ibm.com, hca@...ux.ibm.com, gor@...ux.ibm.com,
        gerald.schaefer@...ux.ibm.com, agordeev@...ux.ibm.com,
        svens@...ux.ibm.com, will@...nel.org,
        Robin Murphy <robin.murphy@....com>,
        linux-kernel@...r.kernel.org,
        Suravee Suthikulpanit <suravee.suthikulpanit@....com>,
        Sven Peter <sven@...npeter.dev>
Subject: Re: [PATCH] iommu: Allow .iotlb_sync_map to fail and handle s390's
 -ENOMEM return

On Tue, 2022-12-13 at 09:11 -0400, Jason Gunthorpe wrote:
> On Tue, Dec 13, 2022 at 01:11:04PM +0100, Niklas Schnelle wrote:
> > --- a/drivers/iommu/tegra-gart.c
> > +++ b/drivers/iommu/tegra-gart.c
> > @@ -252,8 +252,8 @@ static int gart_iommu_of_xlate(struct device *dev,
> >  	return 0;
> >  }
> >  
> > -static void gart_iommu_sync_map(struct iommu_domain *domain, unsigned long iova,
> > -				size_t size)
> > +static int gart_iommu_sync_map(struct iommu_domain *domain, unsigned long iova,
> > +			       size_t size)
> >  {
> >  	FLUSH_GART_REGS(gart_handle);
> >  }
> 
> return 0 ?
> 
> Jason

Stupid me for not at least compile testing on more platforms.
Will send a v2.