linux-kernel - Re: linux-next: Signed-off-by missing for commit in the ftrace tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20221212201146.08c32b28@gandalf.local.home>
Date:   Mon, 12 Dec 2022 20:11:46 -0500
From:   Steven Rostedt <rostedt@...dmis.org>
To:     Stephen Rothwell <sfr@...b.auug.org.au>
Cc:     Masami Hiramatsu <mhiramat@...nel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Linux Next Mailing List <linux-next@...r.kernel.org>
Subject: Re: linux-next: Signed-off-by missing for commit in the ftrace tree

On Tue, 13 Dec 2022 11:42:49 +1100
Stephen Rothwell <sfr@...b.auug.org.au> wrote:

> Hi Steven,
> 
> On Mon, 12 Dec 2022 17:56:42 -0500 Steven Rostedt <rostedt@...dmis.org> wrote:
> >
> > Bah, not sure how this happened. I thought I pulled these patches directly
> > from Masami. Does a rebase change the committer tags? As I probably rebased
> > them on top of my branch.  
> 
> From "git help rebase"
> 
>        --signoff
>            Add a Signed-off-by trailer to all the rebased commits. Note that
>            if --interactive is given then only commits marked to be picked,
>            edited or reworded will have the trailer added.
> 
> So this is not done by default.  Yet another reason to avoid rebasing
> others work unless absolutely necessary.
> 

Yeah, this is temporary, as Masami is still setting up his test
environment, he just asked me to pull his changes on top of mine so that I
can run them.

Now I know what not to do ;-)

-- Steve