linux-kernel - Re: [PATCH] spmi: Add check for remove callback in spmi_drv

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 13 Dec 2022 16:09:30 +0100
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Jishnu Prakash <quic_jprakash@...cinc.com>
Cc:     agross@...nel.org, bjorn.andersson@...aro.org,
        devicetree@...r.kernel.org, robh+dt@...nel.org,
        linus.walleij@...aro.org, quic_kamalw@...cinc.com,
        quic_jestar@...cinc.com, sboyd@...nel.org,
        quic_subbaram@...cinc.com, quic_collinsd@...cinc.com,
        linux-kernel@...r.kernel.org, linux-arm-msm@...r.kernel.org,
        linux-arm-msm-owner@...r.kernel.org
Subject: Re: [PATCH] spmi: Add check for remove callback in spmi_drv_remove
 API

On Tue, Dec 13, 2022 at 07:12:10PM +0530, Jishnu Prakash wrote:
> Hi Greg

Hi, please do not top-post :(

> These are two SPMI drivers without remove callbacks defined:
> 
> drivers/mfd/qcom-spmi-pmic.c
> drivers/mfd/hi6421-spmi-pmic.c

Great, they should be fixed up now, right?

> We made this change after noticing an issue internally with the first one
> above, there was a crash when trying to remove it with rmmod, which is fixed
> by this change.

Then please say that in the changelog text, otherwise we have no idea
_why_ this is needed.  All you said was "add this new check _IF_" and we
have no idea what the answer to "if" is :(

thanks,

greg k-h