linux-kernel - Re: [PATCH] tracing/probe: add a char type to print the character value of traced arguments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202212132319.f9gaRnTT-lkp@intel.com>
Date:   Tue, 13 Dec 2022 23:57:32 +0800
From:   kernel test robot <lkp@...el.com>
To:     Donglin Peng <dolinux.peng@...il.com>, rostedt@...dmis.org
Cc:     oe-kbuild-all@...ts.linux.dev, mhiramat@...nel.org,
        xiehuan09@...il.com, linux-kernel@...r.kernel.org,
        Donglin Peng <dolinux.peng@...il.com>
Subject: Re: [PATCH] tracing/probe: add a char type to print the character
 value of traced arguments

Hi Donglin,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on linus/master]
[also build test WARNING on rostedt-trace/for-next v6.1 next-20221213]
[cannot apply to rostedt-trace/for-next-urgent]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Donglin-Peng/tracing-probe-add-a-char-type-to-print-the-character-value-of-traced-arguments/20221213-195552
patch link:    https://lore.kernel.org/r/20221213115304.3964458-1-dolinux.peng%40gmail.com
patch subject: [PATCH] tracing/probe: add a char type to print the character value of traced arguments
config: parisc-allyesconfig
compiler: hppa-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/c09eb24f0c2c27ce649aed5360dcf3299b636de6
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Donglin-Peng/tracing-probe-add-a-char-type-to-print-the-character-value-of-traced-arguments/20221213-195552
        git checkout c09eb24f0c2c27ce649aed5360dcf3299b636de6
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=parisc SHELL=/bin/bash kernel/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

   In file included from kernel/trace/trace_probe.c:14:
>> kernel/trace/trace_probe.h:146:41: warning: no previous prototype for 'print_type_char' [-Wmissing-prototypes]
     146 | #define PRINT_TYPE_FUNC_NAME(type)      print_type_##type
         |                                         ^~~~~~~~~~~
   kernel/trace/trace_probe.c:34:5: note: in expansion of macro 'PRINT_TYPE_FUNC_NAME'
      34 | int PRINT_TYPE_FUNC_NAME(tname)(struct trace_seq *s, void *data, void *ent)\
         |     ^~~~~~~~~~~~~~~~~~~~
   kernel/trace/trace_probe.c:53:1: note: in expansion of macro 'DEFINE_BASIC_PRINT_TYPE_FUNC'
      53 | DEFINE_BASIC_PRINT_TYPE_FUNC(char, u8, "%c")
         | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~


vim +/print_type_char +146 kernel/trace/trace_probe.h

34fee3a104cea1 Namhyung Kim 2013-11-26  145  
b26c74e116ad84 Namhyung Kim 2013-11-26 @146  #define PRINT_TYPE_FUNC_NAME(type)	print_type_##type
b26c74e116ad84 Namhyung Kim 2013-11-26  147  #define PRINT_TYPE_FMT_NAME(type)	print_type_format_##type
b26c74e116ad84 Namhyung Kim 2013-11-26  148  

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

View attachment "config" of type "text/plain" (315886 bytes)