lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 15 Dec 2022 02:52:50 +0300 From: Serge Semin <Sergey.Semin@...kalelectronics.ru> To: Gustavo Pimentel <gustavo.pimentel@...opsys.com>, Vinod Koul <vkoul@...nel.org>, Rob Herring <robh@...nel.org>, Bjorn Helgaas <bhelgaas@...gle.com>, Lorenzo Pieralisi <lorenzo.pieralisi@....com>, Cai Huoqing <cai.huoqing@...ux.dev>, Robin Murphy <robin.murphy@....com>, Jingoo Han <jingoohan1@...il.com>, Frank Li <Frank.Li@....com>, Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org> CC: Serge Semin <Sergey.Semin@...kalelectronics.ru>, Serge Semin <fancer.lancer@...il.com>, Alexey Malahov <Alexey.Malahov@...kalelectronics.ru>, Pavel Parkhomenko <Pavel.Parkhomenko@...kalelectronics.ru>, Krzysztof WilczyĆski <kw@...ux.com>, caihuoqing <caihuoqing@...du.com>, Yoshihiro Shimoda <yoshihiro.shimoda.uh@...esas.com>, <linux-pci@...r.kernel.org>, <dmaengine@...r.kernel.org>, <linux-kernel@...r.kernel.org>, Gustavo Pimentel <Gustavo.Pimentel@...opsys.com> Subject: [PATCH v7 10/25] dmaengine: dw-edma: Fix DebugFS reg entry type debugfs_entries structure declared in the dw-edma-v0-debugfs.c module contains the DebugFS node' register address. The address is declared as dma_addr_t type, but first it's assigned with virtual CPU IOMEM address and then it's cast back to the virtual address. Even though the castes sandwich will unlikely cause any problem since normally DMA address is at least of the same size as the CPU virtual address, it's at the very least redundant if not to say logically incorrect. Let's fix it by just stop casting the pointer back and worth and just preserve the address as a pointer to void with __iomem qualifier. Fixes: 305aebeff879 ("dmaengine: Add Synopsys eDMA IP version 0 debugfs support") Signed-off-by: Serge Semin <Sergey.Semin@...kalelectronics.ru> Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org> Tested-by: Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org> Acked-by: Vinod Koul <vkoul@...nel.org> --- drivers/dma/dw-edma/dw-edma-v0-debugfs.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/dma/dw-edma/dw-edma-v0-debugfs.c b/drivers/dma/dw-edma/dw-edma-v0-debugfs.c index 5226c9014703..8e61810dea4b 100644 --- a/drivers/dma/dw-edma/dw-edma-v0-debugfs.c +++ b/drivers/dma/dw-edma/dw-edma-v0-debugfs.c @@ -14,7 +14,7 @@ #include "dw-edma-core.h" #define REGS_ADDR(name) \ - ((void __force *)®s->name) + ((void __iomem *)®s->name) #define REGISTER(name) \ { #name, REGS_ADDR(name) } @@ -48,12 +48,13 @@ static struct { struct debugfs_entries { const char *name; - dma_addr_t *reg; + void __iomem *reg; }; static int dw_edma_debugfs_u32_get(void *data, u64 *val) { - void __iomem *reg = (void __force __iomem *)data; + void __iomem *reg = data; + if (dw->chip->mf == EDMA_MF_EDMA_LEGACY && reg >= (void __iomem *)®s->type.legacy.ch) { void __iomem *ptr = ®s->type.legacy.ch; -- 2.38.1
Powered by blists - more mailing lists