linux-kernel - Re: linux-next: build failure after merge of the random tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 13 Dec 2022 22:37:04 -0700
From:   "Jason A. Donenfeld" <Jason@...c4.com>
To:     Stephen Rothwell <sfr@...b.auug.org.au>
Cc:     Theodore Ts'o <tytso@....edu>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Linux Next Mailing List <linux-next@...r.kernel.org>
Subject: Re: linux-next: build failure after merge of the random tree

On Wed, Dec 14, 2022 at 12:53:59PM +1100, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the random tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
> 
> arch/x86/mm/cpu_entry_area.c: In function 'init_cea_offsets':
> arch/x86/mm/cpu_entry_area.c:39:23: error: implicit declaration of function 'prandom_u32_max'; did you mean 'prandom_u32_state'? [-Werror=implicit-function-declaration]
>    39 |                 cea = prandom_u32_max(max_cea);
>       |                       ^~~~~~~~~~~~~~~
>       |                       prandom_u32_state
> net/ipv4/tcp_plb.c: In function 'tcp_plb_update_state_upon_rto':
> net/ipv4/tcp_plb.c:100:18: error: implicit declaration of function 'prandom_u32_max'; did you mean 'prandom_u32_state'? [-Werror=implicit-function-declaration]
>   100 |         pause += prandom_u32_max(pause);
>       |                  ^~~~~~~~~~~~~~~
>       |                  prandom_u32_state
> 
> Caused by commit
> 
>   1effd020f82d ("prandom: remove prandom_u32_max()")
> 
> interacting with some new usages.  Why not leave this removal until
> just after -rc1 has been released?
> 
> I have reverted this commit for today.

The plan was the last chance before rc1, yea. I'll remove it for now so
that it stops breaking -next.

Jason