linux-kernel - Re: [PATCH v2 1/4] dt-bindings: soc: samsung: exynos-sysreg: add dedicated SYSREG compatibles to Exynos850

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <49b6b5f0-02d5-5840-3d0b-f7eff1555133@linaro.org>
Date:   Wed, 14 Dec 2022 09:06:09 +0100
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Sriranjani P <sriranjani.p@...sung.com>,
        'Rob Herring' <robh@...nel.org>
Cc:     krzysztof.kozlowski+dt@...aro.org, devicetree@...r.kernel.org,
        alim.akhtar@...sung.com, pankaj.dubey@...sung.com,
        ravi.patel@...sung.com, linux-kernel@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org,
        linux-samsung-soc@...r.kernel.org
Subject: Re: [PATCH v2 1/4] dt-bindings: soc: samsung: exynos-sysreg: add
 dedicated SYSREG compatibles to Exynos850

On 14/12/2022 05:41, Sriranjani P wrote:
> 
> 
>> -----Original Message-----
>> From: Rob Herring [mailto:robh@...nel.org]
>> Sent: 10 December 2022 02:40
>> To: Sriranjani P <sriranjani.p@...sung.com>
>> Cc: krzysztof.kozlowski+dt@...aro.org; devicetree@...r.kernel.org;
>> alim.akhtar@...sung.com; pankaj.dubey@...sung.com;
>> ravi.patel@...sung.com; linux-kernel@...r.kernel.org; linux-arm-
>> kernel@...ts.infradead.org; linux-samsung-soc@...r.kernel.org
>> Subject: Re: [PATCH v2 1/4] dt-bindings: soc: samsung: exynos-sysreg: add
>> dedicated SYSREG compatibles to Exynos850
>>
>> On Wed, Dec 07, 2022 at 04:20:29PM +0530, Sriranjani P wrote:
>>> Exynos850 has two different SYSREGs, hence add dedicated compatibles
>>> for them and deprecate usage of generic Exynos850 compatible alone.
>>>
>>> Signed-off-by: Sriranjani P <sriranjani.p@...sung.com>
>>> ---
>>>  .../soc/samsung/samsung,exynos-sysreg.yaml        | 15 ++++++++++++---
>>>  1 file changed, 12 insertions(+), 3 deletions(-)
>>>
>>> diff --git
>>> a/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-
>> sysreg.
>>> yaml
>>> b/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-
>> sysreg.
>>> yaml index 4954790eda6c..a37452965100 100644
>>> ---
>>> a/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-
>> sysreg.
>>> yaml
>>> +++
>> b/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sys
>>> +++ reg.yaml
>>> @@ -17,7 +17,6 @@ properties:
>>>                - samsung,exynos3-sysreg
>>>                - samsung,exynos4-sysreg
>>>                - samsung,exynos5-sysreg
>>> -              - samsung,exynos850-sysreg
>>>                - samsung,exynosautov9-sysreg
>>>                - tesla,fsd-cam-sysreg
>>>                - tesla,fsd-fsys0-sysreg @@ -33,9 +32,17 @@ properties:
>>>            - const: samsung,exynos5433-sysreg
>>>            - const: syscon
>>>        - items:
>>> -          - const: samsung,exynos5433-sysreg
>>> +          - enum:
>>> +              - const: samsung,exynos5433-sysreg
>>
>> This says the compatible entry is "const: samsung,exynos5433-sysreg".
>>
>> That should be a schema warning. You did test this, right?
> Thanks for pointing it out, somehow dtbs check not showed any error. Will
> fix it in the next version.

To test binding please run dt_binding_check instead.

Best regards,
Krzysztof