lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <54c37c8f8eb7f35e4bb983b9104bd232758bae7b.camel@mediatek.com>
Date:   Wed, 14 Dec 2022 08:25:30 +0000
From:   Haozhe Chang (常浩哲) 
        <Haozhe.Chang@...iatek.com>
To:     "loic.poulain@...aro.org" <loic.poulain@...aro.org>
CC:     "stephan@...hold.net" <stephan@...hold.net>,
        "oneukum@...e.com" <oneukum@...e.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
        "linux-remoteproc@...r.kernel.org" <linux-remoteproc@...r.kernel.org>,
        "linuxwwan@...el.com" <linuxwwan@...el.com>,
        "m.chetan.kumar@...el.com" <m.chetan.kumar@...el.com>,
        "linux-mediatek@...ts.infradead.org" 
        <linux-mediatek@...ts.infradead.org>,
        Hua Yang (杨华) <Hua.Yang@...iatek.com>,
        "chiranjeevi.rapolu@...ux.intel.com" 
        <chiranjeevi.rapolu@...ux.intel.com>,
        Haijun Liu (刘海军) 
        <haijun.liu@...iatek.com>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "ryazanov.s.a@...il.com" <ryazanov.s.a@...il.com>,
        "kuba@...nel.org" <kuba@...nel.org>,
        Xiayu Zhang (张夏宇) 
        <Xiayu.Zhang@...iatek.com>,
        "pabeni@...hat.com" <pabeni@...hat.com>,
        "edumazet@...gle.com" <edumazet@...gle.com>,
        "chandrashekar.devegowda@...el.com" 
        <chandrashekar.devegowda@...el.com>,
        "johannes@...solutions.net" <johannes@...solutions.net>,
        "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
        "shangxiaojing@...wei.com" <shangxiaojing@...wei.com>,
        Lambert Wang (王伟) 
        <Lambert.Wang@...iatek.com>,
        "matthias.bgg@...il.com" <matthias.bgg@...il.com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "ricardo.martinez@...ux.intel.com" <ricardo.martinez@...ux.intel.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH v5] wwan: core: Support slicing in port TX flow of WWAN
 subsystem

HI Loic

On Thu, 2022-12-01 at 10:56 +0100, Loic Poulain wrote:
> On Thu, 24 Nov 2022 at 08:47, <haozhe.chang@...iatek.com> wrote:
> > 
> > From: haozhe chang <haozhe.chang@...iatek.com>
> > 
> > wwan_port_fops_write inputs the SKB parameter to the TX callback of
> > the WWAN device driver. However, the WWAN device (e.g., t7xx) may
> > have an MTU less than the size of SKB, causing the TX buffer to be
> > sliced and copied once more in the WWAN device driver.
> > 
> > This patch implements the slicing in the WWAN subsystem and gives
> > the WWAN devices driver the option to slice(by frag_len) or not. By
> > doing so, the additional memory copy is reduced.
> > 
> > Meanwhile, this patch gives WWAN devices driver the option to
> > reserve
> > headroom in fragments for the device-specific metadata.
> > 
> > Signed-off-by: haozhe chang <haozhe.chang@...iatek.com>
> 
> Reviewed-by: Loic Poulain <loic.poulain@...aro.org>

I have submitted patch V6 to add a reviewer, do you have any other
suggestions about the patch?

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ