linux-kernel - Re: [PATCH v2 0/2] add hooks for usb suspend and resume

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y5mN+MLD/8oBU1Ay@kroah.com>
Date:   Wed, 14 Dec 2022 09:48:56 +0100
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Puma Hsu <pumahsu@...gle.com>
Cc:     mka@...omium.org, dianders@...omium.org, albertccwang@...gle.com,
        raychi@...gle.com, howardyen@...gle.com, leejj@...gle.com,
        hch@...radead.org, linux-usb@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 0/2] add hooks for usb suspend and resume

On Wed, Dec 14, 2022 at 04:14:54PM +0800, Puma Hsu wrote:
> In mobile, a co-processor can be used for USB audio. When the co-processor
> is working for USB audio, the co-processor is the user/owner of the USB
> driver, and the ACPU is able to sleep in such condition to improve power
> consumption. In order to support this, we need to create hooks in suspend
> and resume functions. We also upload our implementations for reviewing.
> 
> Puma Hsu (2):
>   usb: core: add hooks for usb suspend and resume
>   usb: core: add implementations for usb suspend/resume hooks
> 
>  drivers/usb/core/driver.c              | 36 +++++++++++++
>  drivers/usb/core/usb-hooks-impl-goog.c | 72 ++++++++++++++++++++++++++
>  drivers/usb/core/usb.h                 |  5 ++
>  3 files changed, 113 insertions(+)
>  create mode 100644 drivers/usb/core/usb-hooks-impl-goog.c
> 
> ---
> Changes in v2:
> - Remove the wrong input in the Makefile
> - Change description in commit message
> 
> -- 
> 2.39.0.rc1.256.g54fd8350bd-goog
> 

My review comments on v1 still pertain here.