linux-kernel - Re: [PATCH 1/2] usb: core: add vendor hook for usb suspend and resume

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 14 Dec 2022 17:38:20 +0800
From:   kernel test robot <lkp@...el.com>
To:     Puma Hsu <pumahsu@...gle.com>, gregkh@...uxfoundation.org,
        mka@...omium.org, dianders@...omium.org
Cc:     llvm@...ts.linux.dev, oe-kbuild-all@...ts.linux.dev,
        albertccwang@...gle.com, raychi@...gle.com, howardyen@...gle.com,
        leejj@...gle.com, linux-usb@...r.kernel.org,
        linux-kernel@...r.kernel.org, Puma Hsu <pumahsu@...gle.com>
Subject: Re: [PATCH 1/2] usb: core: add vendor hook for usb suspend and resume

Hi Puma,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on usb/usb-testing]
[also build test WARNING on usb/usb-next usb/usb-linus linus/master v6.1 next-20221214]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Puma-Hsu/add-vendor-hooks-for-usb-suspend-and-resume/20221214-150942
base:   https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing
patch link:    https://lore.kernel.org/r/20221214070650.703793-2-pumahsu%40google.com
patch subject: [PATCH 1/2] usb: core: add vendor hook for usb suspend and resume
config: i386-randconfig-a002
compiler: clang version 14.0.6 (https://github.com/llvm/llvm-project f28c006a5895fc0e329fe15fead81e37457cb1d1)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/c37166c62c494c4e2b7ebbb0a920a47a41a4500a
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Puma-Hsu/add-vendor-hooks-for-usb-suspend-and-resume/20221214-150942
        git checkout c37166c62c494c4e2b7ebbb0a920a47a41a4500a
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=i386 SHELL=/bin/bash drivers/usb/core/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

>> drivers/usb/core/driver.c:40:5: warning: no previous prototype for function 'usb_dev_register_vendor_ops' [-Wmissing-prototypes]
   int usb_dev_register_vendor_ops(struct usb_device_vendor_ops *vendor_ops)
       ^
   drivers/usb/core/driver.c:40:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
   int usb_dev_register_vendor_ops(struct usb_device_vendor_ops *vendor_ops)
   ^
   static 
>> drivers/usb/core/driver.c:50:31: warning: no previous prototype for function 'usb_vendor_get_ops' [-Wmissing-prototypes]
   struct usb_device_vendor_ops *usb_vendor_get_ops(void)
                                 ^
   drivers/usb/core/driver.c:50:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
   struct usb_device_vendor_ops *usb_vendor_get_ops(void)
   ^
   static 
   2 warnings generated.


vim +/usb_dev_register_vendor_ops +40 drivers/usb/core/driver.c

    39	
  > 40	int usb_dev_register_vendor_ops(struct usb_device_vendor_ops *vendor_ops)
    41	{
    42		if (vendor_ops == NULL)
    43			return -EINVAL;
    44	
    45		usb_dev_vendor_ops = vendor_ops;
    46		return 0;
    47	}
    48	EXPORT_SYMBOL_GPL(usb_dev_register_vendor_ops);
    49	
  > 50	struct usb_device_vendor_ops *usb_vendor_get_ops(void)
    51	{
    52		return usb_dev_vendor_ops;
    53	}
    54	EXPORT_SYMBOL_GPL(usb_vendor_get_ops);
    55	
    56	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

View attachment "config" of type "text/plain" (167979 bytes)