linux-kernel - Re: [PATCH v7] igb: Assign random MAC address instead of fail in case of invalid one

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <216119AA-C362-445D-9F04-47AC2A15EC11@126.com>
Date:   Wed, 14 Dec 2022 18:02:53 +0800
From:   梁礼学 <lianglixuehao@....com>
To:     Leon Romanovsky <leon@...nel.org>
Cc:     Tony Nguyen <anthony.l.nguyen@...el.com>,
        Jakub Kicinski <kuba@...nel.org>, linux-kernel@...r.kernel.org,
        Jesse Brandeburg <jesse.brandeburg@...el.com>,
        David Miller <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Paolo Abeni <pabeni@...hat.com>,
        Netdev <netdev@...r.kernel.org>,
        kernel test robot <lkp@...el.com>
Subject: Re: [PATCH v7] igb: Assign random MAC address instead of fail in case
 of invalid one

hi Leon,

Currently this module parameter is only used for igb.
Is the more user-friendly way not to use module parameters?
just like other network card drivers, use random MAC. 
As I submitted [patch v3] before, link: 
https://lore.kernel.org/netdev/20220530105834.97175-1-lianglixuehao@126.com/

Or, can you suggest me how to do it more reasonable?

Thanks

> 2022年12月14日 15:22，Leon Romanovsky <leon@...nel.org> 写道：
> 
> On Tue, Dec 13, 2022 at 07:47:26AM +0000, Lixue Liang wrote:
>> From: Lixue Liang <lianglixue@...atwall.com.cn>
>> 
>> Add the module parameter "allow_invalid_mac_address" to control the
>> behavior. When set to true, a random MAC address is assigned, and the
>> driver can be loaded, allowing the user to correct the invalid MAC address.
>> 
>> Signed-off-by: Lixue Liang <lianglixue@...atwall.com.cn>
> 
> 
> I'm amused that we are in v7 version of module parameter.
> 
> NAK to any module driver parameter. If it is applicable to all drivers,
> please find a way to configure it to more user-friendly. If it is not,
> try to do the same as other drivers do.
> 
> Thanks