linux-kernel - RE: [PATCH v8 tty-next 2/4] serial: 8250_pci1xxxx: Add driver for quad-uart support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <PH7PR11MB595874053E0688490CB0CCE89BE09@PH7PR11MB5958.namprd11.prod.outlook.com>
Date:   Wed, 14 Dec 2022 10:57:17 +0000
From:   <Tharunkumar.Pasumarthi@...rochip.com>
To:     <jirislaby@...nel.org>, <Kumaravel.Thiagarajan@...rochip.com>,
        <linux-kernel@...r.kernel.org>
CC:     <linux-serial@...r.kernel.org>, <gregkh@...uxfoundation.org>,
        <ilpo.jarvinen@...ux.intel.com>, <macro@...am.me.uk>,
        <andriy.shevchenko@...ux.intel.com>, <cang1@...e.co.uk>,
        <colin.i.king@...il.com>, <phil.edworthy@...esas.com>,
        <biju.das.jz@...renesas.com>, <geert+renesas@...der.be>,
        <lukas@...ner.de>, <u.kleine-koenig@...gutronix.de>,
        <wander@...hat.com>, <etremblay@...tech-controls.com>,
        <jk@...abs.org>, <UNGLinuxDriver@...rochip.com>
Subject: RE: [PATCH v8 tty-next 2/4] serial: 8250_pci1xxxx: Add driver for
 quad-uart support

> From: Jiri Slaby <jirislaby@...nel.org>
> Sent: Monday, December 12, 2022 1:15 PM
> To: Kumaravel Thiagarajan - I21417
> <Kumaravel.Thiagarajan@...rochip.com>; linux-kernel@...r.kernel.org
> Subject: Re: [PATCH v8 tty-next 2/4] serial: 8250_pci1xxxx: Add driver for
> quad-uart support
> 
> > +     static int logical_to_physical_port_idx[][MAX_PORTS] = {
> 
> const unsigned.
> 
> > +             {0,  1,  2,  3},/* PCI12000 PCI11010 PCI11101 PCI11400 PCI11414 */
> > +             {0,  1,  2,  3},/* PCI4p */
> > +             {0,  1,  2, -1},/* PCI3p012 */

Hi Jiri,
This array contains negative values. Thereby, not using unsigned. 

Thanks,
Tharun Kumar P