linux-kernel - RE: [PATCH] kbuild: ensure Make >= 3.82 is used

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6c4413040a624b728081e27213fb46a1@AcuMS.aculab.com>
Date:   Wed, 14 Dec 2022 11:05:10 +0000
From:   David Laight <David.Laight@...LAB.COM>
To:     'Nicolas Schier' <nicolas@...sle.eu>,
        Nathan Chancellor <nathan@...nel.org>
CC:     Masahiro Yamada <masahiroy@...nel.org>,
        "linux-kbuild@...r.kernel.org" <linux-kbuild@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Nick Desaulniers <ndesaulniers@...gle.com>
Subject: RE: [PATCH] kbuild: ensure Make >= 3.82 is used

From: Nicolas Schier
> Sent: 13 December 2022 03:59
...
> > > diff --git a/Makefile b/Makefile
> > > index 2dda1e9a717a..66dfc5751470 100644
> > > --- a/Makefile
> > > +++ b/Makefile
> > > @@ -11,6 +11,11 @@ NAME = Hurr durr I'ma ninja sloth
> > >  # Comments in this file are targeted only to the developer, do not
> > >  # expect to learn how to build the kernel reading this file.
> > >
> > > +# Ensure Make >= 3.82

Wouldn't it be better to say either:
	# Ensure gmake supports 'undefine' (added in 3.82)
or:
	# Building with gmake versions prior to 3.82 fails due to
	# bug 'brief description'.
	# Check for 'undefine' support as a surrogate for the bug fix.

    David

-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)