[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <95074120-f4db-0d88-531b-f509d0807796@linaro.org>
Date: Wed, 14 Dec 2022 13:54:41 +0100
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Sibi Sankar <quic_sibis@...cinc.com>, andersson@...nel.org,
krzysztof.kozlowski+dt@...aro.org, robh+dt@...nel.org,
manivannan.sadhasivam@...aro.org
Cc: agross@...nel.org, linux-arm-msm@...r.kernel.org,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
konrad.dybcio@...ainline.org, amit.pundir@...aro.org,
regressions@...mhuis.info, sumit.semwal@...aro.org,
will@...nel.org, catalin.marinas@....com, robin.murphy@....com
Subject: Re: [PATCH 1/4] arm64: dts: qcom: Introduce a carveout for modem
metadata
On 14/12/2022 12:44, Sibi Sankar wrote:
>
>
> On 12/14/22 16:57, Krzysztof Kozlowski wrote:
>> On 13/12/2022 15:07, Sibi Sankar wrote:
>>> Introduce a new carveout for modem metadata. This will serve as a
>>> replacement for the memory region used by MSA to authenticate modem
>>> ELF headers.
>>>
>>> Signed-off-by: Sibi Sankar <quic_sibis@...cinc.com>
>>> ---
>>> arch/arm64/boot/dts/qcom/msm8996-xiaomi-common.dtsi | 6 ++++++
>>> arch/arm64/boot/dts/qcom/msm8996.dtsi | 9 +++++++++
>>> arch/arm64/boot/dts/qcom/msm8998.dtsi | 9 +++++++++
>>> arch/arm64/boot/dts/qcom/sc7180-idp.dts | 7 ++++++-
>>> arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi | 7 ++++++-
>>> arch/arm64/boot/dts/qcom/sc7280-herobrine-lte-sku.dtsi | 7 ++++++-
>>> arch/arm64/boot/dts/qcom/sdm845.dtsi | 9 +++++++++
>>> 7 files changed, 51 insertions(+), 3 deletions(-)
>>>
>>> diff --git a/arch/arm64/boot/dts/qcom/msm8996-xiaomi-common.dtsi b/arch/arm64/boot/dts/qcom/msm8996-xiaomi-common.dtsi
>>> index 5b47b8de69da..4242f8587c19 100644
>>> --- a/arch/arm64/boot/dts/qcom/msm8996-xiaomi-common.dtsi
>>> +++ b/arch/arm64/boot/dts/qcom/msm8996-xiaomi-common.dtsi
>>> @@ -127,6 +127,12 @@
>>> reg = <0x0 0xf6f00000 0x0 0x100000>;
>>> no-map;
>>> };
>>> +
>>> + /delete-node/ memory@...00000;
>>> + mdata_mem: memory@...00000 {
>>> + reg = <0x0 0xf7100000 0x0 0x4000>;
>>> + no-map;
>>> + };
>>> };
>>>
>>> vph_pwr: vph-pwr-regulator {
>>> diff --git a/arch/arm64/boot/dts/qcom/msm8996.dtsi b/arch/arm64/boot/dts/qcom/msm8996.dtsi
>>> index cc65f52bb80f..3f5fb08e2341 100644
>>> --- a/arch/arm64/boot/dts/qcom/msm8996.dtsi
>>> +++ b/arch/arm64/boot/dts/qcom/msm8996.dtsi
>>> @@ -462,6 +462,11 @@
>>> reg = <0x0 0x91500000 0x0 0x200000>;
>>> no-map;
>>> };
>>> +
>>> + mdata_mem: memory@...00000 {
>>> + reg = <0x0 0x91700000 0x0 0x4000>;
>>> + no-map;
>>> + };
>>> };
>>>
>>> rpm-glink {
>>> @@ -2458,6 +2463,10 @@
>>> memory-region = <&mpss_mem>;
>>> };
>>>
>>> + metadata {
>>
>> Does it pass dtbs_check?
>
> ^^ portion of the bindings aren't in yaml yet please see patch 3.
Ah, you touch here multiple files. Please split per SoC.
Best regards,
Krzysztof
Powered by blists - more mailing lists