linux-kernel - Re: [PATCH] scsi: scsi_debug: Delete unreachable code in inquiry_vpd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c1ce375c-0c40-0636-e448-b324467816ef@huawei.com>
Date:   Wed, 14 Dec 2022 09:18:16 +0800
From:   Jason Yan <yanaijie@...wei.com>
To:     John Garry <john.g.garry@...cle.com>, <jejb@...ux.ibm.com>,
        <martin.petersen@...cle.com>, <dgilbert@...erlog.com>
CC:     <linux-scsi@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] scsi: scsi_debug: Delete unreachable code in
 inquiry_vpd_b0()

On 2022/12/13 22:21, John Garry wrote:
> The 2nd return statement in inquiry_vpd_b0() is unreachable, so delete it.
> 
> Signed-off-by: John Garry <john.g.garry@...cle.com>
> 
> diff --git a/drivers/scsi/scsi_debug.c b/drivers/scsi/scsi_debug.c
> index b8a76b89f85a..6f637501539c 100644
> --- a/drivers/scsi/scsi_debug.c
> +++ b/drivers/scsi/scsi_debug.c
> @@ -1511,8 +1511,6 @@ static int inquiry_vpd_b0(unsigned char *arr)
>   	put_unaligned_be64(sdebug_write_same_length, &arr[32]);
>   
>   	return 0x3c; /* Mandatory page length for Logical Block Provisioning */
> -
> -	return sizeof(vpdb0_data);
>   }
>   
>   /* Block device characteristics VPD page (SBC-3) */
> 

Looks good,
Reviewed-by: Jason Yan <yanaijie@...wei.com>