linux-kernel - Re: [PATCH 0/5] Add ACPI trip points parser helpers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJZ5v0h4RCnGv2C+x1m_Uvu5Hmy273wHDLNzYUuJxT_GFxS5qQ@mail.gmail.com>
Date:   Wed, 14 Dec 2022 15:10:13 +0100
From:   "Rafael J. Wysocki" <rafael@...nel.org>
To:     Daniel Lezcano <daniel.lezcano@...aro.org>
Cc:     rafael@...nel.org, srinivas.pandruvada@...ux.intel.com,
        linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/5] Add ACPI trip points parser helpers

On Mon, Dec 12, 2022 at 9:59 PM Daniel Lezcano
<daniel.lezcano@...aro.org> wrote:
>
> Regarding thermal, the ACPI code parsing the trip points is duplicated
> inside different Intel drivers. The generic ACPI thermal driver also
> duplicates this code.
>
> Those ACPI parsing actions are used to define trip points and these
> ones are defined by, and specific to, the backend driver.
>
> The different get_trip_* ops, also very similar between each other,
> are using the specific trip point structure to return the requested
> trip point information.
>
> From there, there is nothing new, all this can be converted to the
> generic trip point.
>
> The first patch provides the functions to parse trip point description
> from the ACPI table but based on the generic trip point structure. The
> other patches convert the different Intel driver to use the ACPI
> functions along with a migration to the generic trip point.

First off, please resend this series with CCs to linux-acpi.

Second, what does it depend on?  I think that it depends on the new
material that hasn't been integrated yet, doesn't it?

> Daniel Lezcano (5):
>   thermal/acpi: Add ACPI trip point routines
>   thermal/drivers/intel: Use generic trip points for intel_pch
>   thermal/drivers/intel: Use generic trip points int340x
>   thermal/drivers/intel: Use generic trip points for quark_dts
>   thermal/drivers/intel: Use generic trip points for
>     processor_thermal_device_pci
>
>  drivers/thermal/Kconfig                       |  13 +
>  drivers/thermal/Makefile                      |   1 +
>  .../int340x_thermal/int340x_thermal_zone.c    | 175 +++---------
>  .../int340x_thermal/int340x_thermal_zone.h    |  10 +-
>  .../processor_thermal_device_pci.c            |  53 ++--
>  drivers/thermal/intel/intel_pch_thermal.c     |  88 ++-----
>  .../thermal/intel/intel_quark_dts_thermal.c   |  45 ++--
>  drivers/thermal/thermal_acpi.c                | 249 ++++++++++++++++++
>  include/linux/thermal.h                       |  15 ++
>  9 files changed, 377 insertions(+), 272 deletions(-)
>  create mode 100644 drivers/thermal/thermal_acpi.c