lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 14 Dec 2022 09:37:11 +0800 From: cy_huang <u0084500@...il.com> To: broonie@...nel.org, lgirdwood@...il.com Cc: m.szyprowski@...sung.com, cy_huang@...htek.com, chiaen_wu@...htek.com, gene_chen@...htek.com, linux-kernel@...r.kernel.org Subject: [PATCH] regulator: core: Fix resolve supply lookup issue From: ChiYuan Huang <cy_huang@...htek.com> >From Marek's log, the previous change modify the parent of rdev. https://lore.kernel.org/all/58b92e75-f373-dae7-7031-8abd465bb874@samsung.com/ In 'regulator_resolve_supply', it uses the parent DT node of rdev as the DT-lookup starting node. But the parent DT node may not exist. This will cause the NULL supply issue. This patch modify the parent of rdev back to the device that provides from 'regulator_config' in 'regulator_register'. Fixes: 8f3cbcd6b440 ("regulator: core: Use different devices for resource allocation and DT lookup") Reported-by: Marek Szyprowski <m.szyprowski@...sung.com> Tested-by: Marek Szyprowski <m.szyprowski@...sung.com> Signed-off-by: ChiYuan Huang <cy_huang@...htek.com> --- drivers/regulator/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c index ace4ecc..729c453 100644 --- a/drivers/regulator/core.c +++ b/drivers/regulator/core.c @@ -5540,7 +5540,7 @@ regulator_register(struct device *dev, /* register with sysfs */ rdev->dev.class = ®ulator_class; - rdev->dev.parent = dev; + rdev->dev.parent = config->dev; dev_set_name(&rdev->dev, "regulator.%lu", (unsigned long) atomic_inc_return(®ulator_no)); dev_set_drvdata(&rdev->dev, rdev); -- 2.7.4
Powered by blists - more mailing lists