linux-kernel - Re: [PATCH 3/3] NFS: nfs_encode_fh: Remove S

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <92B44C88-61B5-4450-B027-60F9F7A614FF@oracle.com>
Date:   Wed, 14 Dec 2022 15:09:12 +0000
From:   Chuck Lever III <chuck.lever@...cle.com>
To:     Anna Schumaker <anna@...nel.org>,
        Trond Myklebust <trond.myklebust@...merspace.com>
CC:     Linux NFS Mailing List <linux-nfs@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>,
        linux-fsdevel <linux-fsdevel@...r.kernel.org>,
        Jeff Layton <jlayton@...nel.org>,
        Al Viro <viro@...iv.linux.org.uk>, Ian Kent <raven@...maw.net>,
        "chris.chilvers@...sbroker.com" <chris.chilvers@...sbroker.com>,
        "david.young@...sbroker.com" <david.young@...sbroker.com>,
        "luis.turcitu@...sbroker.com" <luis.turcitu@...sbroker.com>,
        "david@...ma-star.at" <david@...ma-star.at>,
        "benmaynard@...gle.com" <benmaynard@...gle.com>,
        Richard Weinberger <richard@....at>
Subject: Re: [PATCH 3/3] NFS: nfs_encode_fh: Remove S_AUTOMOUNT check



> On Dec 7, 2022, at 3:43 AM, Richard Weinberger <richard@....at> wrote:
> 
> Now with NFSD being able to cross into auto mounts,
> the check can be removed.
> 
> Signed-off-by: Richard Weinberger <richard@....at>
> ---
> fs/nfs/export.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/nfs/export.c b/fs/nfs/export.c
> index 01596f2d0a1e..0a5ee1754d50 100644
> --- a/fs/nfs/export.c
> +++ b/fs/nfs/export.c
> @@ -42,7 +42,7 @@ nfs_encode_fh(struct inode *inode, __u32 *p, int *max_len, struct inode *parent)
> 	dprintk("%s: max fh len %d inode %p parent %p",
> 		__func__, *max_len, inode, parent);
> 
> -	if (*max_len < len || IS_AUTOMOUNT(inode)) {
> +	if (*max_len < len) {
> 		dprintk("%s: fh len %d too small, required %d\n",
> 			__func__, *max_len, len);
> 		*max_len = len;
> -- 
> 2.26.2
> 

I plan to take this through the nfsd tree, thus this one needs
an Ack from the NFS client maintainers.

--
Chuck Lever