linux-kernel - Re: [PATCH] Add HP Stream 8 to bytcr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <92358ff1-86ca-76b0-c4f3-3d4e0dddc80a@redhat.com>
Date:   Wed, 14 Dec 2022 16:42:34 +0100
From:   Hans de Goede <hdegoede@...hat.com>
To:     Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>,
        Moises Cardona <moisesmcardona@...il.com>,
        cezary.rojewski@...el.com
Cc:     liam.r.girdwood@...ux.intel.com, peter.ujfalusi@...ux.intel.com,
        yung-chuan.liao@...ux.intel.com, ranjani.sridharan@...ux.intel.com,
        kai.vehmanen@...ux.intel.com, broonie@...nel.org, perex@...ex.cz,
        tiwai@...e.com, oder_chiou@...ltek.com, akihiko.odaki@...il.com,
        alsa-devel@...a-project.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Add HP Stream 8 to bytcr_rt5640.c

Hi,

On 12/13/22 20:04, Pierre-Louis Bossart wrote:
> 
> 
> On 12/13/22 11:35, Moises Cardona wrote:
>> The HP Stream 8 tablet is identical to the HP Stream 7 in terms of the PCB,
>> with the exception of the added SIM Card Slot. 
>> Therefore, I'm submitting this patch which properly initializes the audio 
>> and enables the headphone jack to work, just like it does in the 
>> HP Stream 7.
>>
>> Signed-off-by: Moises Cardona <moisesmcardona@...il.com>
> 
> Acked-by: Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>

Note this is the old version which wrongly contains the
BYT_RT5640_MONO_SPEAKER flag.

Mark, please merge the new version (which unfortunately
was not marked as v2) which correctly drops
the BYT_RT5640_MONO_SPEAKER flag.

(this tablet has 2 speakers so it should not have the mono flag)

Regards,

Hans


> 
>> ---
>>  sound/soc/intel/boards/bytcr_rt5640.c | 11 +++++++++++
>>  1 file changed, 11 insertions(+)
>>
>> diff --git a/sound/soc/intel/boards/bytcr_rt5640.c b/sound/soc/intel/boards/bytcr_rt5640.c
>> index fb9d9e271845..1d964b1ceff4 100644
>> --- a/sound/soc/intel/boards/bytcr_rt5640.c
>> +++ b/sound/soc/intel/boards/bytcr_rt5640.c
>> @@ -796,6 +796,17 @@ static const struct dmi_system_id byt_rt5640_quirk_table[] = {
>>  					BYT_RT5640_SSP0_AIF1 |
>>  					BYT_RT5640_MCLK_EN),
>>  	},
>> +	{	/* HP Stream 8 */
>> +		.matches = {
>> +			DMI_EXACT_MATCH(DMI_SYS_VENDOR, "Hewlett-Packard"),
>> +			DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "HP Stream 8 Tablet"),
>> +		},
>> +		.driver_data = (void *)(BYTCR_INPUT_DEFAULTS |
>> +					BYT_RT5640_MONO_SPEAKER |
>> +					BYT_RT5640_JD_NOT_INV |
>> +					BYT_RT5640_SSP0_AIF1 |
>> +					BYT_RT5640_MCLK_EN),
>> +	},
>>  	{	/* I.T.Works TW891 */
>>  		.matches = {
>>  			DMI_EXACT_MATCH(DMI_SYS_VENDOR, "To be filled by O.E.M."),
>