linux-kernel - Re: [PATCH] dt-bindings: arm: qcom: add board-id/msm-id for MSM8956, SDM636 and SM4250

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <65ccd0c9-8bd9-fc3c-ef33-78b905adf294@linaro.org>
Date:   Wed, 14 Dec 2022 17:45:49 +0100
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Marijn Suijten <marijn.suijten@...ainline.org>,
        Bjorn Andersson <andersson@...nel.org>
Cc:     Andy Gross <agross@...nel.org>,
        Konrad Dybcio <konrad.dybcio@...aro.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] dt-bindings: arm: qcom: add board-id/msm-id for MSM8956,
 SDM636 and SM4250

On 14/12/2022 16:29, Marijn Suijten wrote:
> On 2022-12-14 16:06:05, Krzysztof Kozlowski wrote:
>> Allow qcom,board-id and qcom,msm-id leagcy properties on these older
>> platforms: MSM8956, SDM636 and SM4250.  Also mention more OnePlus
>> devices using modified qcom,board-id field.
>>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> 
> Reviewed-by: Marijn Suijten <marijn.suijten@...ainline.org>
> 
>> ---
>>  Documentation/devicetree/bindings/arm/qcom.yaml | 5 +++++
>>  1 file changed, 5 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
>> index d45e2129fce3..cfb7f5caf606 100644
>> --- a/Documentation/devicetree/bindings/arm/qcom.yaml
>> +++ b/Documentation/devicetree/bindings/arm/qcom.yaml
>> @@ -925,15 +925,18 @@ allOf:
>>                - qcom,apq8026
>>                - qcom,apq8094
>>                - qcom,apq8096
>> +              - qcom,msm8956
> 
> I am certain this (and msm8976) were added in [1] but it somehow got
> lost when that was merged as 05c0c38dc752 ("dt-bindings: arm: qcom:
> Document msm8956 and msm8976 SoC and devices")?
> 
> Should we also add qcom,msm8976 or only when a user for that board is
> added?

Bjorn,
You need to fix your scripts. It's not the first time when applied patch
is changed and its pieces are gone.

This is patchwork:
https://patchwork.kernel.org/project/linux-arm-msm/patch/20221111120156.48040-9-angelogioacchino.delregno@collabora.com/

This is git:
https://git.kernel.org/pub/scm/linux/kernel/git/qcom/linux.git/commit/?h=arm64-for-6.2&id=05c0c38dc752eb9244e53d72ce1030f36153daf8

Two different patches.


> 
>>                - qcom,msm8992
>>                - qcom,msm8994
>>                - qcom,msm8996
>>                - qcom,msm8998
>>                - qcom,sdm630
>>                - qcom,sdm632
>> +              - qcom,sdm636
>>                - qcom,sdm845
>>                - qcom,sdx55
>>                - qcom,sdx65
>> +              - qcom,sm4250
> 
> qcom,sm6115 could be added as well unless you rather leave that to the
> person(s) adding the board compatible later on.

There is no board, I think, so I did not add compatible.

Best regards,
Krzysztof