linux-kernel - Re: [PATCH v3] block/blk-iocost (gcc13): keep large values in a new enum

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <974973f8-c703-59aa-5afe-40b33429fdbb@kernel.dk>
Date:   Wed, 14 Dec 2022 09:56:48 -0700
From:   Jens Axboe <axboe@...nel.dk>
To:     "Jiri Slaby (SUSE)" <jirislaby@...nel.org>,
        Tejun Heo <tj@...nel.org>
Cc:     linux-kernel@...r.kernel.org, Martin Liska <mliska@...e.cz>,
        Josef Bacik <josef@...icpanda.com>, cgroups@...r.kernel.org,
        linux-block@...r.kernel.org
Subject: Re: [PATCH v3] block/blk-iocost (gcc13): keep large values in a new
 enum

On 12/13/22 5:08 AM, Jiri Slaby (SUSE) wrote:
> Since gcc13, each member of an enum has the same type as the enum [1]. And
> that is inherited from its members. Provided:
>   VTIME_PER_SEC_SHIFT     = 37,
>   VTIME_PER_SEC           = 1LLU << VTIME_PER_SEC_SHIFT,
>   ...
>   AUTOP_CYCLE_NSEC        = 10LLU * NSEC_PER_SEC,
> the named type is unsigned long.
> 
> This generates warnings with gcc-13:
>   block/blk-iocost.c: In function 'ioc_weight_prfill':
>   block/blk-iocost.c:3037:37: error: format '%u' expects argument of type 'unsigned int', but argument 4 has type 'long unsigned int'
> 
>   block/blk-iocost.c: In function 'ioc_weight_show':
>   block/blk-iocost.c:3047:34: error: format '%u' expects argument of type 'unsigned int', but argument 3 has type 'long unsigned int'
> 
> So split the anonumois enum with large values to a separate enum, so

anonymous?

-- 
Jens Axboe