linux-kernel - Re: [PATCH bpf-next] bpf: prevent leak of lsm program after failed attach

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <167098441652.18507.17827174898852419883.git-patchwork-notify@kernel.org>
Date:   Wed, 14 Dec 2022 02:20:16 +0000
From:   patchwork-bot+netdevbpf@...nel.org
To:     Milan Landaverde <milan@...verde.com>
Cc:     bpf@...r.kernel.org, ast@...nel.org, daniel@...earbox.net,
        john.fastabend@...il.com, andrii@...nel.org, martin.lau@...ux.dev,
        song@...nel.org, yhs@...com, kpsingh@...nel.org, sdf@...gle.com,
        haoluo@...gle.com, jolsa@...nel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH bpf-next] bpf: prevent leak of lsm program after failed attach

Hello:

This patch was applied to bpf/bpf-next.git (master)
by Martin KaFai Lau <martin.lau@...nel.org>:

On Tue, 13 Dec 2022 12:57:14 -0500 you wrote:
> In [0], we added the ability to bpf_prog_attach LSM programs to cgroups,
> but in our validation to make sure the prog is meant to be attached to
> BPF_LSM_CGROUP, we return too early if the check fails. This results in
> lack of decrementing prog's refcnt (through bpf_prog_put)
> leaving the LSM program alive past the point of the expected lifecycle.
> This fix allows for the decrement to take place.
> 
> [...]

Here is the summary with links:
  - [bpf-next] bpf: prevent leak of lsm program after failed attach
    https://git.kernel.org/bpf/bpf-next/c/2958c237fd1e

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html