linux-kernel - Re: [PATCH] x86: lib: Separate instruction decoder MMIO type from MMIO trace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y5oy0vwZQAwzkDkr@zx2c4.com>
Date:   Wed, 14 Dec 2022 13:32:18 -0700
From:   "Jason A. Donenfeld" <Jason@...c4.com>
To:     Ricardo Neri <ricardo.neri-calderon@...ux.intel.com>
Cc:     tglx@...utronix.de, mingo@...hat.com, dave.hansen@...ux.intel.com,
        bp@...en8.de, x86@...nel.org, hpa@...or.com,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] x86: lib: Separate instruction decoder MMIO type from
 MMIO trace

On Wed, Dec 14, 2022 at 11:56:29AM -0800, Ricardo Neri wrote:
> > @@ -347,7 +347,7 @@ static int handle_mmio(struct pt_regs *regs, struct ve_info *ve)
> >  	unsigned long *reg, val, vaddr;
> >  	char buffer[MAX_INSN_SIZE];
> >  	struct insn insn = {};
> > -	enum mmio_type mmio;
> > +	enum insn_mmio_type mmio;
> 
> It would be good to preserve the reverse fir order in the variable
> declarations.
>
> > -	enum mmio_type mmio;
> > +	enum insn_mmio_type mmio;
> 
> Same here.

Maintaining reverse Christmas trees would be in the holiday spirit,
after all. I'll send a v2.

Jason