linux-kernel - Re: [PATCH v4] HID: multitouch: Add quirks for flipped axes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202212150654.WLschjDI-lkp@intel.com>
Date:   Thu, 15 Dec 2022 06:26:48 +0800
From:   kernel test robot <lkp@...el.com>
To:     Allen Ballway <ballway@...omium.org>
Cc:     oe-kbuild-all@...ts.linux.dev, benjamin.tissoires@...hat.com,
        dmitry.torokhov@...il.com, dtor@...omium.org, jikos@...nel.org,
        linux-input@...r.kernel.org, linux-kernel@...r.kernel.org,
        rydberg@...math.org
Subject: Re: [PATCH v4] HID: multitouch: Add quirks for flipped axes

Hi Allen,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on hid/for-next]
[also build test ERROR on linus/master v6.1 next-20221214]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Allen-Ballway/HID-multitouch-Add-quirks-for-flipped-axes/20221215-021448
base:   https://git.kernel.org/pub/scm/linux/kernel/git/hid/hid.git for-next
patch link:    https://lore.kernel.org/r/20221214181334.323360-1-ballway%40chromium.org
patch subject: [PATCH v4] HID: multitouch: Add quirks for flipped axes
config: x86_64-randconfig-a006
compiler: gcc-11 (Debian 11.3.0-8) 11.3.0
reproduce (this is a W=1 build):
        # https://github.com/intel-lab-lkp/linux/commit/6f10db9d7ffacd402e75fb3089f3347d3a24236e
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Allen-Ballway/HID-multitouch-Add-quirks-for-flipped-axes/20221215-021448
        git checkout 6f10db9d7ffacd402e75fb3089f3347d3a24236e
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

   ld: drivers/hid/hid-quirks.o: in function `hid_lookup_quirk':
>> drivers/hid/hid-quirks.c:1304: undefined reference to `i2c_hid_get_dmi_quirks'
   pahole: .tmp_vmlinux.btf: No such file or directory
   .btf.vmlinux.bin.o: file not recognized: file format not recognized


vim +1304 drivers/hid/hid-quirks.c

  1258	
  1259	/**
  1260	 * hid_lookup_quirk - return any quirks associated with a HID device
  1261	 * @hdev: the HID device to look for
  1262	 *
  1263	 * Description:
  1264	 *     Given a HID device, return any quirks associated with that device.
  1265	 *
  1266	 * Return: an unsigned long quirks value.
  1267	 */
  1268	unsigned long hid_lookup_quirk(const struct hid_device *hdev)
  1269	{
  1270		unsigned long quirks = 0;
  1271		const struct hid_device_id *quirk_entry = NULL;
  1272	
  1273		/* NCR devices must not be queried for reports */
  1274		if (hdev->bus == BUS_USB &&
  1275		    hdev->vendor == USB_VENDOR_ID_NCR &&
  1276		    hdev->product >= USB_DEVICE_ID_NCR_FIRST &&
  1277		    hdev->product <= USB_DEVICE_ID_NCR_LAST)
  1278			return HID_QUIRK_NO_INIT_REPORTS;
  1279	
  1280		/* These devices must be ignored if version (bcdDevice) is too old */
  1281		if (hdev->bus == BUS_USB && hdev->vendor == USB_VENDOR_ID_JABRA) {
  1282			switch (hdev->product) {
  1283			case USB_DEVICE_ID_JABRA_SPEAK_410:
  1284				if (hdev->version < 0x0111)
  1285					return HID_QUIRK_IGNORE;
  1286				break;
  1287			case USB_DEVICE_ID_JABRA_SPEAK_510:
  1288				if (hdev->version < 0x0214)
  1289					return HID_QUIRK_IGNORE;
  1290				break;
  1291			}
  1292		}
  1293	
  1294		mutex_lock(&dquirks_lock);
  1295		quirk_entry = hid_exists_dquirk(hdev);
  1296		if (quirk_entry)
  1297			quirks = quirk_entry->driver_data;
  1298		else
  1299			quirks = hid_gets_squirk(hdev);
  1300		mutex_unlock(&dquirks_lock);
  1301	
  1302		/* Get quirks specific to I2C devices */
  1303		if (hdev->bus == BUS_I2C)
> 1304			quirks |= i2c_hid_get_dmi_quirks(hdev->vendor, hdev->product);

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

View attachment "config" of type "text/plain" (111600 bytes)