[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <Y5ukugBX0VGz8lBQ@monkey>
Date: Thu, 15 Dec 2022 14:50:34 -0800
From: Mike Kravetz <mike.kravetz@...cle.com>
To: Andrew Morton <akpm@...ux-foundation.org>
Cc: linux-mm@...ck.org, linux-kernel@...r.kernel.org,
Muchun Song <songmuchun@...edance.com>,
Miaohe Lin <linmiaohe@...wei.com>,
David Hildenbrand <david@...hat.com>,
Peter Xu <peterx@...hat.com>,
Naoya Horiguchi <naoya.horiguchi@...ux.dev>,
"Aneesh Kumar K . V" <aneesh.kumar@...ux.vnet.ibm.com>,
James Houghton <jthoughton@...gle.com>,
Mina Almasry <almasrymina@...gle.com>
Subject: Re: [PATCH 1/2] hugetlb: really allocate vma lock for all sharable
vmas
On 12/15/22 14:37, Andrew Morton wrote:
> On Mon, 12 Dec 2022 15:50:41 -0800 Mike Kravetz <mike.kravetz@...cle.com> wrote:
>
> > Commit bbff39cc6cbc ("hugetlb: allocate vma lock for all sharable vmas")
> > removed the pmd sharable checks in the vma lock helper routines.
> > However, it left the functional version of helper routines behind #ifdef
> > CONFIG_ARCH_WANT_HUGE_PMD_SHARE. Therefore, the vma lock is not being
> > used for sharable vmas on architectures that do not support pmd sharing.
> > On these architectures, a potential fault/truncation race is exposed
> > that could leave pages in a hugetlb file past i_size until the file is
> > removed.
> >
> > Move the functional vma lock helpers outside the ifdef, and remove the
> > non-functional stubs. Since the vma lock is not just for pmd sharing,
> > rename the routine __vma_shareable_flags_pmd.
> >
> > Fixes: bbff39cc6cbc ("hugetlb: allocate vma lock for all sharable vmas")
>
> So I assume we want this backported to 6.1? I added a cc:stable.
>
> The [2/2] patch is, I think, 6.3-rc1 material?
That is correct. Sorry, I forgot the cc:stable.
--
Mike Kravetz
Powered by blists - more mailing lists