linux-kernel - Re: [PATCH] cxl/acpi: fix null dereference on probe for missing ACPI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20221215060410.2p653tgqw35q6wbz@offworld>
Date:   Wed, 14 Dec 2022 22:04:10 -0800
From:   Davidlohr Bueso <dave@...olabs.net>
To:     Luis Chamberlain <mcgrof@...nel.org>
Cc:     Dan Williams <dan.j.williams@...el.com>,
        Lucas De Marchi <lucas.de.marchi@...il.com>,
        alison.schofield@...el.com, vishal.l.verma@...el.com,
        ira.weiny@...el.com, bwidawsk@...nel.org, a.manzanares@...sung.com,
        linux-cxl@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] cxl/acpi: fix null dereference on probe for missing
 ACPI_COMPANION()

On Wed, 14 Dec 2022, Luis Chamberlain wrote:

>Groovy thanks. Progress, but still fails now on the cxl-xor-region.sh line 29
>
>https://gist.github.com/mcgrof/aeac639365a651bd77f143cf38eb7493

Unrelated, but looking at this log I noticed that we should limit the amount
of noise "Bypassing cpu_cache_invalidate_memregion() for testing" emits.

Thanks,
Davidlohr

-----8<-------------------------------------
[PATCH] cxl/region: Only warn about cpu_cache_invalidate_memregion() once

No need for more than once per region.

Signed-off-by: Davidlohr Bueso <dave@...olabs.net>
---
  drivers/cxl/core/region.c | 3 +--
  1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/cxl/core/region.c b/drivers/cxl/core/region.c
index b1281f528d7f..f367d1c10357 100644
--- a/drivers/cxl/core/region.c
+++ b/drivers/cxl/core/region.c
@@ -2006,8 +2006,7 @@ static int cxl_region_invalidate_memregion(struct cxl_region *cxlr)
  
  	if (!cpu_cache_has_invalidate_memregion()) {
  		if (IS_ENABLED(CONFIG_CXL_REGION_INVALIDATION_TEST)) {
-			dev_warn(
-				&cxlr->dev,
+			dev_WARN_ONCE(&cxlr->dev, 1,
  				"Bypassing cpu_cache_invalidate_memregion() for testing!\n");
  			clear_bit(CXL_REGION_F_INCOHERENT, &cxlr->flags);
  			return 0;
-- 
2.38.1