linux-kernel - Re: [RFC PATCH] mm/mempolicy: Fix memory leak in set_mempolicy_home

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87k02tcgzv.fsf@yhuang6-desk2.ccr.corp.intel.com>
Date:   Thu, 15 Dec 2022 14:34:28 +0800
From:   "Huang, Ying" <ying.huang@...el.com>
To:     Mathieu Desnoyers <mathieu.desnoyers@...icios.com>
Cc:     Andrew Morton <akpm@...ux-foundation.org>,
        linux-kernel@...r.kernel.org,
        "Aneesh Kumar K . V" <aneesh.kumar@...ux.ibm.com>,
        Ben Widawsky <ben.widawsky@...el.com>,
        Dave Hansen <dave.hansen@...ux.intel.com>,
        Feng Tang <feng.tang@...el.com>,
        Michal Hocko <mhocko@...nel.org>,
        Andrea Arcangeli <aarcange@...hat.com>,
        Mel Gorman <mgorman@...hsingularity.net>,
        Mike Kravetz <mike.kravetz@...cle.com>,
        Randy Dunlap <rdunlap@...radead.org>,
        Vlastimil Babka <vbabka@...e.cz>,
        Andi Kleen <ak@...ux.intel.com>,
        Dan Williams <dan.j.williams@...el.com>,
        linux-api@...r.kernel.org, stable@...r.kernel.org
Subject: Re: [RFC PATCH] mm/mempolicy: Fix memory leak in
 set_mempolicy_home_node system call

Mathieu Desnoyers <mathieu.desnoyers@...icios.com> writes:

> When encountering any vma in the range with policy other than MPOL_BIND
> or MPOL_PREFERRED_MANY, an error is returned without issuing a mpol_put
> on the policy just allocated with mpol_dup().
>
> This allows arbitrary users to leak kernel memory.
>
> Fixes: c6018b4b2549 ("mm/mempolicy: add set_mempolicy_home_node syscall")
> Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@...icios.com>
> Cc: Aneesh Kumar K.V <aneesh.kumar@...ux.ibm.com>
> Cc: Ben Widawsky <ben.widawsky@...el.com>
> Cc: Dave Hansen <dave.hansen@...ux.intel.com>
> Cc: Feng Tang <feng.tang@...el.com>
> Cc: Michal Hocko <mhocko@...nel.org>
> Cc: Andrea Arcangeli <aarcange@...hat.com>
> Cc: Mel Gorman <mgorman@...hsingularity.net>
> Cc: Mike Kravetz <mike.kravetz@...cle.com>
> Cc: Randy Dunlap <rdunlap@...radead.org>
> Cc: Vlastimil Babka <vbabka@...e.cz>
> Cc: Andi Kleen <ak@...ux.intel.com>
> Cc: Dan Williams <dan.j.williams@...el.com>
> Cc: Huang Ying <ying.huang@...el.com>
> Cc: <linux-api@...r.kernel.org>
> Cc: Andrew Morton <akpm@...ux-foundation.org>
> Cc: stable@...r.kernel.org # 5.17+

Reviewed-by: "Huang, Ying" <ying.huang@...el.com>

Thanks!

> ---
>  mm/mempolicy.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/mm/mempolicy.c b/mm/mempolicy.c
> index 61aa9aedb728..02c8a712282f 100644
> --- a/mm/mempolicy.c
> +++ b/mm/mempolicy.c
> @@ -1540,6 +1540,7 @@ SYSCALL_DEFINE4(set_mempolicy_home_node, unsigned long, start, unsigned long, le
>  		 * the home node for vmas we already updated before.
>  		 */
>  		if (new->mode != MPOL_BIND && new->mode != MPOL_PREFERRED_MANY) {
> +			mpol_put(new);
>  			err = -EOPNOTSUPP;
>  			break;
>  		}