linux-kernel - Re: [PATCH 5/6] LoongArch: Add raw_show_trace to enable guess unwinder default

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fb7740c7-1bdb-ad71-50f9-284551032568@loongson.cn>
Date:   Thu, 15 Dec 2022 14:48:27 +0800
From:   Jinyang He <hejinyang@...ngson.cn>
To:     Huacai Chen <chenhuacai@...nel.org>
Cc:     WANG Xuerui <kernel@...0n.name>,
        Qing Zhang <zhangqing@...ngson.cn>, loongarch@...ts.linux.dev,
        linux-kernel@...r.kernel.org, Steven Rostedt <rostedt@...dmis.org>,
        Masami Hiramatsu <mhiramat@...nel.org>,
        Mark Rutland <mark.rutland@....com>
Subject: Re: [PATCH 5/6] LoongArch: Add raw_show_trace to enable guess
 unwinder default

On 2022-12-15 14:15, Huacai Chen wrote:

> Hi, Jinyang,
>
> Is this patch really necessary?

Of course not. When I developed and tested this series, I always compile
the kernel twice, maybe more :-(, to do comparisons between the result from
guess and result from prologue to determine whether prologue is effective.
Also, the guess_unwinder might be more reliable if function_graph is
enabled, because prologue_unwinder may stop by strange code flow. If you
think it is meaningless, I'll remove it in the next version. It doesn't
affect other patches in this series.

Thanks,

Jinyang