[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <fe761bbe-96f9-75ae-b4be-e94b718abac3@linaro.org>
Date: Thu, 15 Dec 2022 08:06:16 +0100
From: Philippe Mathieu-Daudé <philmd@...aro.org>
To: Srinivasa Rao Mandadapu <quic_srivasam@...cinc.com>,
linux-remoteproc@...r.kernel.org, agross@...nel.org,
andersson@...nel.org, lgirdwood@...il.com, broonie@...nel.org,
robh+dt@...nel.org, quic_plai@...cinc.com, bgoswami@...cinc.com,
perex@...ex.cz, tiwai@...e.com, srinivas.kandagatla@...aro.org,
quic_rohkumar@...cinc.com, linux-arm-msm@...r.kernel.org,
linux-kernel@...r.kernel.org, judyhsiao@...omium.org,
devicetree@...r.kernel.org, krzysztof.kozlowski@...aro.org,
mathieu.poirier@...aro.org, corbet@....net,
Stephen Boyd <swboyd@...omium.org>
Subject: Re: [PATCH v2 1/2] remoteproc: elf_loader: Update resource table name
check
On 13/12/22 10:48, Srinivasa Rao Mandadapu wrote:
> Update the way of checking resource table name with prefix
> substring search instead of complete string search.
> In general Qualcomm DSP binary is prepared by combining different elfs,
Maybe 'ELFs'? (twice).
> hence section header name (e.g. .resource_table), appended with elf name
> to differentiate with same section of different elfs.
Please include here the section info parsed by readelf as an example,
as suggested by Stephen in your v1:
https://lore.kernel.org/linux-remoteproc/CAE-0n52cNite8-4HDoQcsZ+UvZFkJU8c5oUjxPB5ag5WP6E9=g@mail.gmail.com/
> Signed-off-by: Srinivasa Rao Mandadapu <quic_srivasam@...cinc.com>
> ---
> Changes since v1:
> -- Update the commit message.
> -- Use strstarts instead of strstr.
>
> drivers/remoteproc/remoteproc_elf_loader.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/remoteproc/remoteproc_elf_loader.c b/drivers/remoteproc/remoteproc_elf_loader.c
> index 5a412d7..77330d6 100644
> --- a/drivers/remoteproc/remoteproc_elf_loader.c
> +++ b/drivers/remoteproc/remoteproc_elf_loader.c
> @@ -272,7 +272,7 @@ find_table(struct device *dev, const struct firmware *fw)
> u64 offset = elf_shdr_get_sh_offset(class, shdr);
> u32 name = elf_shdr_get_sh_name(class, shdr);
>
> - if (strcmp(name_table + name, ".resource_table"))
> + if (!strstarts(name_table + name, ".resource_table"))
> continue;
>
> table = (struct resource_table *)(elf_data + offset);
Powered by blists - more mailing lists