linux-kernel - Re: [PATCH v2 1/1] i2c: designware: set pinctrl recovery information from device pinctrl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 15 Dec 2022 08:17:55 +0800
From:   kernel test robot <lkp@...el.com>
To:     Hanna Hawa <hhhawa@...zon.com>, jarkko.nikula@...ux.intel.com,
        andriy.shevchenko@...ux.intel.com, mika.westerberg@...ux.intel.com,
        jsd@...ihalf.com
Cc:     llvm@...ts.linux.dev, oe-kbuild-all@...ts.linux.dev,
        linux-i2c@...r.kernel.org, linux-kernel@...r.kernel.org,
        dwmw@...zon.co.uk, benh@...zon.com, ronenk@...zon.com,
        talel@...zon.com, jonnyc@...zon.com, hanochu@...zon.com,
        farbere@...zon.com, itamark@...zon.com,
        Hanna Hawa <hhhawa@...zon.com>
Subject: Re: [PATCH v2 1/1] i2c: designware: set pinctrl recovery information
 from device pinctrl

Hi Hanna,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on wsa/i2c/for-next]
[also build test ERROR on linus/master v6.1 next-20221214]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Hanna-Hawa/i2c-designware-set-pinctrl-recovery-information-from-device-pinctrl/20221214-222910
base:   https://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git i2c/for-next
patch link:    https://lore.kernel.org/r/20221214142725.23881-1-hhhawa%40amazon.com
patch subject: [PATCH v2 1/1] i2c: designware: set pinctrl recovery information from device pinctrl
config: x86_64-randconfig-a014
compiler: clang version 14.0.6 (https://github.com/llvm/llvm-project f28c006a5895fc0e329fe15fead81e37457cb1d1)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/6e428843e5a6779565aae5f37fe0093ad526f139
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Hanna-Hawa/i2c-designware-set-pinctrl-recovery-information-from-device-pinctrl/20221214-222910
        git checkout 6e428843e5a6779565aae5f37fe0093ad526f139
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

>> drivers/i2c/busses/i2c-designware-master.c:829:16: error: no member named 'pins' in 'struct device'
           if (dev->dev->pins && dev->dev->pins->p)
               ~~~~~~~~  ^
   drivers/i2c/busses/i2c-designware-master.c:829:34: error: no member named 'pins' in 'struct device'
           if (dev->dev->pins && dev->dev->pins->p)
                                 ~~~~~~~~  ^
   drivers/i2c/busses/i2c-designware-master.c:830:30: error: no member named 'pins' in 'struct device'
                   rinfo->pinctrl = dev->dev->pins->p;
                                    ~~~~~~~~  ^
   3 errors generated.


vim +829 drivers/i2c/busses/i2c-designware-master.c

   822	
   823	static int i2c_dw_init_recovery_info(struct dw_i2c_dev *dev)
   824	{
   825		struct i2c_bus_recovery_info *rinfo = &dev->rinfo;
   826		struct i2c_adapter *adap = &dev->adapter;
   827		struct gpio_desc *gpio;
   828	
 > 829		if (dev->dev->pins && dev->dev->pins->p)
   830			rinfo->pinctrl = dev->dev->pins->p;
   831	
   832		gpio = devm_gpiod_get_optional(dev->dev, "scl", GPIOD_OUT_HIGH);
   833		if (IS_ERR_OR_NULL(gpio))
   834			return PTR_ERR_OR_ZERO(gpio);
   835	
   836		rinfo->scl_gpiod = gpio;
   837	
   838		gpio = devm_gpiod_get_optional(dev->dev, "sda", GPIOD_IN);
   839		if (IS_ERR(gpio))
   840			return PTR_ERR(gpio);
   841		rinfo->sda_gpiod = gpio;
   842	
   843		rinfo->recover_bus = i2c_generic_scl_recovery;
   844		rinfo->prepare_recovery = i2c_dw_prepare_recovery;
   845		rinfo->unprepare_recovery = i2c_dw_unprepare_recovery;
   846		adap->bus_recovery_info = rinfo;
   847	
   848		dev_info(dev->dev, "running with gpio recovery mode! scl%s",
   849			 rinfo->sda_gpiod ? ",sda" : "");
   850	
   851		return 0;
   852	}
   853	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

View attachment "config" of type "text/plain" (166803 bytes)