linux-kernel - Re: [PATCH v2 07/21] block, blksnap: init() and exit() functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y5rpKXuJxqeUYfJP@infradead.org>
Date:   Thu, 15 Dec 2022 01:30:17 -0800
From:   Christoph Hellwig <hch@...radead.org>
To:     Sergei Shtepa <sergei.shtepa@...am.com>
Cc:     axboe@...nel.dk, corbet@....net, linux-block@...r.kernel.org,
        linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 07/21] block, blksnap: init() and exit() functions

On Fri, Dec 09, 2022 at 03:23:17PM +0100, Sergei Shtepa wrote:
> +	result = diff_io_init();
> +	if (result)
> +		return result;
> +
> +	result = snapimage_init();
> +	if (result)
> +		return result;
> +
> +	result = tracker_init();
> +	if (result)
> +		return result;

You need to clean up all these initialization if a later one fails.

Also, does this really need a separate file?  Any good reason to
not just keep the tiny amount of init code in ctrl.c?

> +static void __exit blk_snap_exit(void)
> +{
> +	pr_info("Unloading module\n");

Also we try to avoid these verbose messages for new code normally.