linux-kernel - Re: [PATCH v2 13/21] block, blksnap: functions and structures for performing block I/O operations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y5rxnsKpQga5GRzY@infradead.org>
Date:   Thu, 15 Dec 2022 02:06:22 -0800
From:   Christoph Hellwig <hch@...radead.org>
To:     Sergei Shtepa <sergei.shtepa@...am.com>
Cc:     axboe@...nel.dk, corbet@....net, linux-block@...r.kernel.org,
        linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 13/21] block, blksnap: functions and structures for
 performing block I/O operations

> +	bio = bio_alloc_bioset(diff_region->bdev, nr_iovecs, opf, gfp_mask,
> +			       &diff_io_bioset);
> +	if (unlikely(!bio)) {
> +		if (is_nowait)
> +			ret = -EAGAIN;
> +		else
> +			ret = -ENOMEM;
> +		goto fail;

bio_alloc_bioset can't fail for the !is_nowait case.