linux-kernel - Re: [PATCH] HID: amd_sfh: Add support for tablet-mode-switch sensor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <nycvar.YFH.7.76.2212151125090.9000@cbobk.fhfr.pm>
Date:   Thu, 15 Dec 2022 11:26:46 +0100 (CET)
From:   Jiri Kosina <jikos@...nel.org>
To:     Adrian Freund <adrian@...und.io>
cc:     kernel test robot <lkp@...el.com>, linux-input@...r.kernel.org,
        oe-kbuild-all@...ts.linux.dev, linux-kernel@...r.kernel.org,
        Basavaraj Natikar <basavaraj.natikar@....com>,
        Benjamin Tissoires <benjamin.tissoires@...hat.com>,
        Ivan Dovgal <iv.dovg@...il.com>,
        "Luke D . Jones" <luke@...nes.dev>
Subject: Re: [PATCH] HID: amd_sfh: Add support for tablet-mode-switch
 sensor

On Thu, 15 Dec 2022, Adrian Freund wrote:

> >     In file included from drivers/hid/amd-sfh-hid/sfh1_1/amd_sfh_desc.c:15:
> >>> drivers/hid/amd-sfh-hid/sfh1_1/../hid_descriptor/amd_sfh_hid_report_desc.h:649:17:
> >>> warning: 'tms_report_descriptor' defined but not used
> >>> [-Wunused-const-variable=]
> >       649 | static const u8 tms_report_descriptor[] = {
> >           |                 ^~~~~~~~~~~~~~~~~~~~~
> hid_descriptor/amd_sfh_hid_report_desc.h is included from both
> hid_descriptor/amd_sfh_hid_desc.c and sfh1_1/amd_sfh_desc.c, the first of
> which has 4 usages of tms_report_descriptor. The later is for sensor fusion
> hub 1.1. I don't have access to a devices using sfh1.1, so I can't add support
> for the tablet mode switch there, causing the variable to be unused for that
> import.

I'd say either move the rdesc directly to 
hid_descriptor/amd_sfh_hid_desc.c, or alternatively mark it with 
__attribute__((used)).

-- 
Jiri Kosina
SUSE Labs