[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <0d35858867ae1c3de899d6162aa39e013daff435.camel@redhat.com>
Date: Thu, 15 Dec 2022 12:29:22 +0100
From: Paolo Abeni <pabeni@...hat.com>
To: Arun Ramadoss <arun.ramadoss@...rochip.com>,
linux-kernel@...r.kernel.org, netdev@...r.kernel.org
Cc: woojung.huh@...rochip.com, UNGLinuxDriver@...rochip.com,
andrew@...n.ch, vivien.didelot@...il.com, f.fainelli@...il.com,
olteanv@...il.com, davem@...emloft.net, edumazet@...gle.com,
kuba@...nel.org, linux@...linux.org.uk, Tristram.Ha@...rochip.com,
ceggers@...i.de
Subject: Re: [Patch net] net: dsa: microchip: remove IRQF_TRIGGER_FALLING in
request_threaded_irq
On Tue, 2022-12-13 at 15:44 +0530, Arun Ramadoss wrote:
> KSZ swithes used interrupts for detecting the phy link up and down.
> During registering the interrupt handler, it used IRQF_TRIGGER_FALLING
> flag. But this flag has to be retrieved from device tree instead of hard
> coding in the driver,
Out of sheer ignorance, why?
> so removing the flag.
It looks like the device tree currently lack such item, so this is
effecivelly breaking phy linkup/linkdown?
What am I missing?
Thanks!
Paolo
Powered by blists - more mailing lists