linux-kernel - Re: [PATCH 2/2] ASoC: max98088: fix initial dai mute state

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 15 Dec 2022 12:00:45 +0000
From:   Mark Brown <broonie@...nel.org>
To:     Marco Felsch <m.felsch@...gutronix.de>
Cc:     Rouven Czerwinski <r.czerwinski@...gutronix.de>,
        Liam Girdwood <lgirdwood@...il.com>,
        Jaroslav Kysela <perex@...ex.cz>,
        Takashi Iwai <tiwai@...e.com>, kernel@...gutronix.de,
        alsa-devel@...a-project.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] ASoC: max98088: fix initial dai mute state

On Thu, Dec 15, 2022 at 10:17:47AM +0100, Marco Felsch wrote:
> On 22-12-13, Mark Brown wrote:

> > > +       snd_soc_component_update_bits(component, M98088_REG_2F_LVL_DAI1_PLAY,
> > > +               M98088_DAI_MUTE_MASK, M98088_DAI_MUTE);
> > > +       snd_soc_component_update_bits(component, M98088_REG_31_LVL_DAI2_PLAY,
> > > +               M98088_DAI_MUTE_MASK, M98088_DAI_MUTE);
> > > +

> > Won't this be broken again after suspend?  The device gets powered off
> > over suspend, then when it powers on again with the output unmuted
> > nothing will do another write since the register is already in the state
> > in the cache.

> I didn't found any suspend logic within the driver. Is this handled
> within the ASoC core?

Register save and restore for the device won't be.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)