linux-kernel - Re: [PATCH v7 1/6] DONOTMERGE: arm64: dts: ti: Add TI TPS65219 PMIC support for AM642 SK board.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y5tGzjgcAWPqdFNE@sirena.org.uk>
Date:   Thu, 15 Dec 2022 16:09:50 +0000
From:   Mark Brown <broonie@...nel.org>
To:     jerome Neanne <jneanne@...libre.com>
Cc:     Wadim Egorov <W.Egorov@...tec.de>,
        "lgirdwood@...il.com" <lgirdwood@...il.com>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>, "nm@...com" <nm@...com>,
        "kristo@...nel.org" <kristo@...nel.org>,
        "dmitry.torokhov@...il.com" <dmitry.torokhov@...il.com>,
        "krzysztof.kozlowski+dt@...aro.org" 
        <krzysztof.kozlowski+dt@...aro.org>,
        "catalin.marinas@....com" <catalin.marinas@....com>,
        "will@...nel.org" <will@...nel.org>,
        "lee@...nel.org" <lee@...nel.org>,
        "tony@...mide.com" <tony@...mide.com>,
        "vigneshr@...com" <vigneshr@...com>,
        "shawnguo@...nel.org" <shawnguo@...nel.org>,
        "geert+renesas@...der.be" <geert+renesas@...der.be>,
        "dmitry.baryshkov@...aro.org" <dmitry.baryshkov@...aro.org>,
        "marcel.ziswiler@...adex.com" <marcel.ziswiler@...adex.com>,
        "vkoul@...nel.org" <vkoul@...nel.org>,
        "biju.das.jz@...renesas.com" <biju.das.jz@...renesas.com>,
        "arnd@...db.de" <arnd@...db.de>,
        "jeff@...undy.com" <jeff@...undy.com>, "afd@...com" <afd@...com>,
        "khilman@...libre.com" <khilman@...libre.com>,
        "narmstrong@...libre.com" <narmstrong@...libre.com>,
        "msp@...libre.com" <msp@...libre.com>,
        "j-keerthy@...com" <j-keerthy@...com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-input@...r.kernel.org" <linux-input@...r.kernel.org>,
        "linux-omap@...r.kernel.org" <linux-omap@...r.kernel.org>
Subject: Re: [PATCH v7 1/6] DONOTMERGE: arm64: dts: ti: Add TI TPS65219 PMIC
 support for AM642 SK board.

On Thu, Dec 15, 2022 at 04:51:40PM +0100, jerome Neanne wrote:
> On 15/12/2022 16:09, Wadim Egorov wrote:

> > I am testing your PMIC patches on a AM62 based board with a similar setup and
> > running into the following error

> >      VDDSHV5_SDIO: bypassed regulator has no supply!
> >      VDDSHV5_SDIO: will resolve supply early: ldo1
> >      VDDSHV5_SDIO: supplied by regulator-dummy
> >      VDDSHV5_SDIO: failed to get the current voltage: -EINVAL

> > Have you noticed problems with LDO1 and bypass mode?

> I did not noticed this on am642 board but IIRC this rail was not used. I
> heard about similar issue reported to me by Nishanth M with a fix proposal
> here:
> https://gist.github.com/nmenon/e4dd6ef6afe31bc9750fa6cbee8d3e25

That proposal looks really non-idiomatic and quite unusual, if there's a
fixed voltage supply to the LDO I'd expect to see it modeled as a fixed
voltage regulator.  I'm not sure what the use of bypass here is trying
to accomplish TBH.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)