linux-kernel - Re: [PATCH v4 1/2] usb: serial: add support for CH348

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 16 Dec 2022 00:27:56 +0800
From:   kernel test robot <lkp@...el.com>
To:     Corentin Labbe <clabbe@...libre.com>, gregkh@...uxfoundation.org,
        johan@...nel.org
Cc:     oe-kbuild-all@...ts.linux.dev, linux-kernel@...r.kernel.org,
        linux-usb@...r.kernel.org, Corentin Labbe <clabbe@...libre.com>
Subject: Re: [PATCH v4 1/2] usb: serial: add support for CH348

Hi Corentin,

I love your patch! Yet something to improve:

[auto build test ERROR on johan-usb-serial/usb-next]
[also build test ERROR on johan-usb-serial/usb-linus usb/usb-testing usb/usb-next usb/usb-linus tty/tty-testing tty/tty-next tty/tty-linus linus/master v6.1 next-20221215]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Corentin-Labbe/usb-serial-add-support-for-CH348/20221215-220335
base:   https://git.kernel.org/pub/scm/linux/kernel/git/johan/usb-serial.git usb-next
patch link:    https://lore.kernel.org/r/20221215140045.2584886-2-clabbe%40baylibre.com
patch subject: [PATCH v4 1/2] usb: serial: add support for CH348
config: nios2-randconfig-r033-20221215
compiler: nios2-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/1b3deaef8fe547770a928ad03bbd1b3688733a2a
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Corentin-Labbe/usb-serial-add-support-for-CH348/20221215-220335
        git checkout 1b3deaef8fe547770a928ad03bbd1b3688733a2a
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=nios2 SHELL=/bin/bash drivers/usb/serial/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

>> drivers/usb/serial/ch348.c:644:33: error: initialization of 'void (*)(struct tty_struct *, struct usb_serial_port *, const struct ktermios *)' from incompatible pointer type 'void (*)(struct tty_struct *, struct usb_serial_port *, struct ktermios *)' [-Werror=incompatible-pointer-types]
     644 |         .set_termios =          ch348_set_termios,
         |                                 ^~~~~~~~~~~~~~~~~
   drivers/usb/serial/ch348.c:644:33: note: (near initialization for 'ch348_device.set_termios')
   cc1: some warnings being treated as errors

Kconfig warnings: (for reference only)
   WARNING: unmet direct dependencies detected for DEBUG_MAPLE_TREE
   Depends on [n]: DEBUG_KERNEL [=n]
   Selected by [y]:
   - TEST_MAPLE_TREE [=y] && RUNTIME_TESTING_MENU [=y]


vim +644 drivers/usb/serial/ch348.c

   635	
   636	static struct usb_serial_driver ch348_device = {
   637		.driver = {
   638			.owner = THIS_MODULE,
   639			.name = "ch348",
   640		},
   641		.id_table =		ch348_ids,
   642		.num_ports =		CH348_MAXPORT,
   643		.open =			ch348_open,
 > 644		.set_termios =		ch348_set_termios,
   645		.process_read_urb =	ch348_process_read_urb,
   646		.prepare_write_buffer =	ch348_prepare_write_buffer,
   647		.probe =		ch348_probe,
   648		.calc_num_ports =	ch348_calc_num_ports,
   649		.release =		ch348_release,
   650	};
   651	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

View attachment "config" of type "text/plain" (177551 bytes)