linux-kernel - Re: [PATCH] kmsan: include linux/vmalloc.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 15 Dec 2022 17:39:37 +0100
From:   Alexander Potapenko <glider@...gle.com>
To:     Arnd Bergmann <arnd@...nel.org>
Cc:     Andrew Morton <akpm@...ux-foundation.org>,
        Arnd Bergmann <arnd@...db.de>, Marco Elver <elver@...gle.com>,
        Dmitry Vyukov <dvyukov@...gle.com>, kasan-dev@...glegroups.com,
        linux-mm@...ck.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] kmsan: include linux/vmalloc.h

On Thu, Dec 15, 2022 at 5:30 PM Arnd Bergmann <arnd@...nel.org> wrote:
>
> From: Arnd Bergmann <arnd@...db.de>
>
> This is needed for the vmap/vunmap declarations:
>
> mm/kmsan/kmsan_test.c:316:9: error: implicit declaration of function 'vmap' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
>         vbuf = vmap(pages, npages, VM_MAP, PAGE_KERNEL);
>                ^
> mm/kmsan/kmsan_test.c:316:29: error: use of undeclared identifier 'VM_MAP'
>         vbuf = vmap(pages, npages, VM_MAP, PAGE_KERNEL);
>                                    ^
> mm/kmsan/kmsan_test.c:322:3: error: implicit declaration of function 'vunmap' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
>                 vunmap(vbuf);
>                 ^
>
> Fixes: 8ed691b02ade ("kmsan: add tests for KMSAN")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
Reviewed-by: Alexander Potapenko <glider@...gle.com>

> ---
>  mm/kmsan/kmsan_test.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/mm/kmsan/kmsan_test.c b/mm/kmsan/kmsan_test.c
> index eb44ef3c5f29..088e21a48dc4 100644
> --- a/mm/kmsan/kmsan_test.c
> +++ b/mm/kmsan/kmsan_test.c
> @@ -22,6 +22,7 @@
>  #include <linux/spinlock.h>
>  #include <linux/string.h>
>  #include <linux/tracepoint.h>
> +#include <linux/vmalloc.h>
>  #include <trace/events/printk.h>
>
>  static DEFINE_PER_CPU(int, per_cpu_var);
> --
> 2.35.1
>


-- 
Alexander Potapenko
Software Engineer

Google Germany GmbH
Erika-Mann-Straße, 33
80636 München

Geschäftsführer: Paul Manicle, Liana Sebastian
Registergericht und -nummer: Hamburg, HRB 86891
Sitz der Gesellschaft: Hamburg