linux-kernel - Re: [External] Re: [RFC PATCH] blk-throtl: Introduce sync queue for write ios

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 15 Dec 2022 06:42:34 -1000
From:   Tejun Heo <tj@...nel.org>
To:     hanjinke <hanjinke.666@...edance.com>
Cc:     josef@...icpanda.com, axboe@...nel.dk, cgroups@...r.kernel.org,
        linux-block@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [External] Re: [RFC PATCH] blk-throtl: Introduce sync queue for
 write ios

Hello,

Sorry about the delay.

On Tue, Dec 13, 2022 at 11:55:16AM +0800, hanjinke wrote:
> If sq->queue[] were only classfied SYNC and ASYNC, some things may become a
> little difficult to handle。As we put sync write and read together into SYNC
> queue, the two may influence each other.
> Whit wbps=1M and rbps=100M configured, sync io likely be throtled while read
> ios after it may can be dispatched within the limit. In that case,
> maybe we should scan the whole SYNC queue to check read io.

Ah, yeah, you're right. The configuration per-rw so we have to split within.
Will review your latest patch.

Thanks.

-- 
tejun