linux-kernel - Re: [PATCH] reset: ti-sci: fix compile test dependencies

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6c8d0815-a64c-a4ea-4bc9-d38a2b6c3121@infradead.org>
Date:   Thu, 15 Dec 2022 09:08:08 -0800
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Arnd Bergmann <arnd@...nel.org>,
        Philipp Zabel <p.zabel@...gutronix.de>,
        Nishanth Menon <nm@...com>
Cc:     Arnd Bergmann <arnd@...db.de>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] reset: ti-sci: fix compile test dependencies



On 12/15/22 09:00, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@...db.de>
> 
> The SCI reset driver can be compile testing on targets that
> do not support the SCI firmware, but it fails to link when
> the firmware driver is built as a module, and the reset driver
> is built-in:
> 
> arm-linux-gnueabi-ld: drivers/reset/reset-ti-sci.o: in function `ti_sci_reset_probe':
> reset-ti-sci.c:(.text+0x422): undefined reference to `devm_ti_sci_get_handle'
> 
> Prevent this configuration by limiting the compile test
> to configurations without SCI firmware.
> 
> Fixes: a6af504184c9 ("reset: ti-sci: Allow building under COMPILE_TEST")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

https://lore.kernel.org/lkml/20221030055636.3139-1-rdunlap@infradead.org/

> ---
>  drivers/reset/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/reset/Kconfig b/drivers/reset/Kconfig
> index de176c2fbad9..2a52c990d4fe 100644
> --- a/drivers/reset/Kconfig
> +++ b/drivers/reset/Kconfig
> @@ -257,7 +257,7 @@ config RESET_SUNXI
>  
>  config RESET_TI_SCI
>  	tristate "TI System Control Interface (TI-SCI) reset driver"
> -	depends on TI_SCI_PROTOCOL || COMPILE_TEST
> +	depends on TI_SCI_PROTOCOL || (COMPILE_TEST && TI_SCI_PROTOCOL=n)
>  	help
>  	  This enables the reset driver support over TI System Control Interface
>  	  available on some new TI's SoCs. If you wish to use reset resources

-- 
~Randy