linux-kernel - Re: [PATCH] pinctrl: at91: convert to NOIRQ_SYSTEM_SLEEP_PM_OPS

Open Source and information security mailing list archives

Date:   Thu, 15 Dec 2022 17:26:02 +0000
From:   <Ryan.Wanner@...rochip.com>
To:     <arnd@...nel.org>, <Ludovic.Desroches@...rochip.com>,
        <linus.walleij@...aro.org>, <Nicolas.Ferre@...rochip.com>,
        <alexandre.belloni@...tlin.com>, <Claudiu.Beznea@...rochip.com>
CC:     <arnd@...db.de>, <andriy.shevchenko@...ux.intel.com>,
        <slark_xiao@....com>, <linux-arm-kernel@...ts.infradead.org>,
        <linux-gpio@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] pinctrl: at91: convert to NOIRQ_SYSTEM_SLEEP_PM_OPS

On 12/15/22 09:42, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@...db.de>
> 
> With the old SET_NOIRQ_SYSTEM_SLEEP_PM_OPS, some configs result in a
> build warning:
> 
> drivers/pinctrl/pinctrl-at91.c:1668:12: error: 'at91_gpio_resume' defined but not used [-Werror=unused-function]
>  1668 | static int at91_gpio_resume(struct device *dev)
>       |            ^~~~~~~~~~~~~~~~
> drivers/pinctrl/pinctrl-at91.c:1650:12: error: 'at91_gpio_suspend' defined but not used [-Werror=unused-function]
>  1650 | static int at91_gpio_suspend(struct device *dev)
>       |            ^~~~~~~~~~~~~~~~~
> 
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Reviewed-by: Ryan Wanner <Ryan.Wanner@...rochip.com>

Thanks Arnd, best,
Ryan
> ---
>  drivers/pinctrl/pinctrl-at91.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/pinctrl/pinctrl-at91.c b/drivers/pinctrl/pinctrl-at91.c
> index 1e1813d7c550..cf2423855a80 100644
> --- a/drivers/pinctrl/pinctrl-at91.c
> +++ b/drivers/pinctrl/pinctrl-at91.c
> @@ -1923,7 +1923,7 @@ static int at91_gpio_probe(struct platform_device *pdev)
>  }
> 
>  static const struct dev_pm_ops at91_gpio_pm_ops = {
> -       SET_NOIRQ_SYSTEM_SLEEP_PM_OPS(at91_gpio_suspend, at91_gpio_resume)
> +       NOIRQ_SYSTEM_SLEEP_PM_OPS(at91_gpio_suspend, at91_gpio_resume)
>  };
> 
>  static struct platform_driver at91_gpio_driver = {
> --
> 2.35.1
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@...ts.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives