[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-ID: <20221215110544.7e832e41@kernel.org>
Date: Thu, 15 Dec 2022 11:05:44 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: David Decotigny <ddecotig@...gle.com>,
David Ahern <dsahern@...nel.org>
Cc: "Mahesh Bandewar (महेश बंडेवार)" <maheshb@...gle.com>,
David Decotigny <decot+git@...gle.com>,
"David S. Miller" <davem@...emloft.net>,
Eric Dumazet <edumazet@...gle.com>,
Paolo Abeni <pabeni@...hat.com>, netdev@...r.kernel.org,
linux-kernel@...r.kernel.org,
Nikolay Aleksandrov <razor@...ckwall.org>,
"Denis V. Lunev" <den@...nvz.org>,
Daniel Borkmann <daniel@...earbox.net>,
Chen Zhongjin <chenzhongjin@...wei.com>,
Yuwei Wang <wangyuweihx@...il.com>,
Alexander Mikhalitsyn <alexander.mikhalitsyn@...tuozzo.com>,
Thomas Zeitlhofer <thomas.zeitlhofer+lkml@...it.at>
Subject: Re: [PATCH v1 1/1] net: neigh: persist proxy config across link
flaps
On Wed, 14 Dec 2022 22:18:04 -0800 David Decotigny wrote:
> I don't think this patch is changing that part of the behavior: we still
> flush the cached nd entries when the link flaps. What we don't remove are
> the pneigh_entry-es (ip neigh add proxy ...) attached to the device where
> the link flaps: those are configured once and this patch ensures that they
> survive the link flaps as long as the netdev stays admin-up. When
> the netdev is brought admin-down, we keep the behavior we had before the
> patch.
Makes sense. This is not urgent, tho, right?
David A, do you agree and should we treat this as a fix with
Fixes: 859bd2ef1fc1 ("net: Evict neighbor entries on carrier down")
added?
Reminder: please bottom post on the list
Powered by blists - more mailing lists