linux-kernel - Re: [RFC][PATCH] ACPI: tracing: Have ACPI debug go to tracing ring buffer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20221215141146.6ceb7cf2@gandalf.local.home>
Date:   Thu, 15 Dec 2022 14:11:46 -0500
From:   Steven Rostedt <rostedt@...dmis.org>
To:     Joel Fernandes <joel@...lfernandes.org>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        Linux Trace Kernel <linux-trace-kernel@...r.kernel.org>,
        linux-acpi@...r.kernel.org,
        "Rafael J. Wysocki" <rafael@...nel.org>,
        Len Brown <lenb@...nel.org>,
        Masami Hiramatsu <mhiramat@...nel.org>,
        Brian Norris <briannorris@...omium.org>,
        Ross Zwisler <zwisler@...gle.com>,
        Ching-lin Yu <chinglinyu@...gle.com>
Subject: Re: [RFC][PATCH] ACPI: tracing: Have ACPI debug go to tracing ring
 buffer

On Thu, 15 Dec 2022 18:45:37 +0000
Joel Fernandes <joel@...lfernandes.org> wrote:

> Wouldn't it be better to also check trace_acpi_print_enabled() here in the
> else if() condition, along with IS_ENABLED()? That way if the CONFIG is
> enabled but the tracepoint is not enabled, at least the messages will go to
> dmesg instead of skipped.

I really don't want that. This was purposely done to be mutually exclusive.
The reason I added this in the first place, is because too much enabled
will render the system useless if printk() is used.

After boot up, if I had enabled all debug events and then I were to disable
the acpi tracepoint, it will likely render the system useless again if it
were to switch over to printk.

-- Steve