linux-kernel - Re: [RFC PATCH] futex: Fix futex_waitv() hrtimer debug object leak on kcalloc error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20221215201750.kefgg25ptsjbmq2u@offworld>
Date:   Thu, 15 Dec 2022 12:17:50 -0800
From:   Davidlohr Bueso <dave@...olabs.net>
To:     Mathieu Desnoyers <mathieu.desnoyers@...icios.com>
Cc:     Peter Zijlstra <peterz@...radead.org>,
        linux-kernel@...r.kernel.org,
        Andre Almeida <andrealmeid@...labora.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>,
        Darren Hart <dvhart@...radead.org>, stable@...r.kernel.org
Subject: Re: [RFC PATCH] futex: Fix futex_waitv() hrtimer debug object leak
 on kcalloc error

On Wed, 14 Dec 2022, Mathieu Desnoyers wrote:

>In a scenario where kcalloc() fails to allocate memory, the futex_waitv
>system call immediately returns -ENOMEM without invoking
>destroy_hrtimer_on_stack(). When CONFIG_DEBUG_OBJECTS_TIMERS=y, this
>results in leaking a timer debug object.
>
>Fixes: bf69bad38cf6 ("futex: Implement sys_futex_waitv()")
>Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@...icios.com>
>Cc: Andre Almeida <andrealmeid@...labora.com>
>Cc: Peter Zijlstra (Intel) <peterz@...radead.org>
>Cc: Thomas Gleixner <tglx@...utronix.de>
>Cc: Ingo Molnar <mingo@...hat.com>
>Cc: Darren Hart <dvhart@...radead.org>
>Cc: Davidlohr Bueso <dave@...olabs.net>
>Cc: stable@...r.kernel.org # v5.16+

Reviewed-by: Davidlohr Bueso <dave@...olabs.net>