linux-kernel - RE: [PATCH v9 tty-next 2/4] serial: 8250_pci1xxxx: Add driver for quad-uart support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 16 Dec 2022 10:31:38 +0000
From:   <Tharunkumar.Pasumarthi@...rochip.com>
To:     <andriy.shevchenko@...ux.intel.com>
CC:     <Kumaravel.Thiagarajan@...rochip.com>,
        <linux-kernel@...r.kernel.org>, <linux-serial@...r.kernel.org>,
        <gregkh@...uxfoundation.org>, <jirislaby@...nel.org>,
        <ilpo.jarvinen@...ux.intel.com>, <macro@...am.me.uk>,
        <cang1@...e.co.uk>, <colin.i.king@...il.com>,
        <phil.edworthy@...esas.com>, <biju.das.jz@...renesas.com>,
        <geert+renesas@...der.be>, <lukas@...ner.de>,
        <u.kleine-koenig@...gutronix.de>, <wander@...hat.com>,
        <etremblay@...tech-controls.com>, <jk@...abs.org>,
        <UNGLinuxDriver@...rochip.com>
Subject: RE: [PATCH v9 tty-next 2/4] serial: 8250_pci1xxxx: Add driver for
 quad-uart support

> From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> Sent: Friday, December 16, 2022 3:09 PM
> To: Tharunkumar Pasumarthi - I67821
> <Tharunkumar.Pasumarthi@...rochip.com>
> Subject: Re: [PATCH v9 tty-next 2/4] serial: 8250_pci1xxxx: Add driver for
> quad-uart support
> 
> > From this sequence, it seemed like, kernel takes care of freeing irq
> > and calling pci_free_irq_vectors is not required.
> 
> Technically you are correct, but... read this discussion, and pay attention to
> what Christoph said there:
> 
> https://lore.kernel.org/linux-serial/0250c46e-da6c-71f3-50ae-
> b7c17fd0bd2c@...mens.com/

Okay, got it. Will use pci_free_irq_vectors. 
Also, do you suggest using pci_enable_device instead of pcim_enable_device (to maintain consistency
of using non managed APIs throughout driver)?

Thanks,
Tharun Kumar P