linux-kernel - Re: [PATCH] regulator: tps65219: fix Wextra warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <67efe55d-e5cd-46c1-97e4-c9f3a5884a07@app.fastmail.com>
Date:   Fri, 16 Dec 2022 11:18:24 +0100
From:   "Arnd Bergmann" <arnd@...db.de>
To:     "Mark Brown" <broonie@...nel.org>,
        "Arnd Bergmann" <arnd@...nel.org>
Cc:     "Tony Lindgren" <tony@...mide.com>,
        "Liam Girdwood" <lgirdwood@...il.com>,
        "Jerome Neanne" <jneanne@...libre.com>,
        "Axel Lin" <axel.lin@...ics.com>,
        "Yang Li" <yang.lee@...ux.alibaba.com>,
        "Yang Yingliang" <yangyingliang@...wei.com>,
        Linux-OMAP <linux-omap@...r.kernel.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] regulator: tps65219: fix Wextra warning

On Thu, Dec 15, 2022, at 17:48, Mark Brown wrote:
> On Thu, Dec 15, 2022 at 05:41:28PM +0100, Arnd Bergmann wrote:
>
>> -		tps65219_get_rdev_by_name(irq_type->regulator_name, rdevtbl, rdev);
>> -		if (rdev < 0) {
>> +		error = tps65219_get_rdev_by_name(irq_type->regulator_name, rdevtbl, rdev);
>> +		if (error) {
>>  			dev_err(tps->dev, "Failed to get rdev for %s\n",
>>  				irq_type->regulator_name);
>> -			return -EINVAL;
>> +			return error;
>
> This will shut up the warning but is leaving the use of the
> uninitialised rdev (which I'm kind of disappointed the static checkers
> didn't pick up on).  rdev needs to be passed by reference into the
> function, or set from the return value.

Right, I didn't look far enough to see what the function is
actually trying to do here, and that it completely fails to
do that.

I see that the bug was introduced between the first [1] and
second []2] version of the driver, but don't see why. I'll
leave it up to Jerome to address the problem, he's still
in the middle of posting the rest of the series that has
not yet been merged, so it makes sense for him to test it
all together.

    Arnd

[1] https://lore.kernel.org/lkml/20220719091742.3221-9-jneanne@baylibre.com/
[2] https://lore.kernel.org/lkml/20220726103355.17684-10-jneanne@baylibre.com/