linux-kernel - Re: [PATCH] cma:tracing: Print alloc result in trace_cma_alloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20221216065739.30511197@gandalf.local.home>
Date:   Fri, 16 Dec 2022 06:57:39 -0500
From:   Steven Rostedt <rostedt@...dmis.org>
To:     Wenchao Hao <haowenchao@...wei.com>
Cc:     Masami Hiramatsu <mhiramat@...nel.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        <linux-kernel@...r.kernel.org>, <linux-mm@...ck.org>,
        <liuzhiqiang26@...wei.com>, <linfeilong@...wei.com>
Subject: Re: [PATCH] cma:tracing: Print alloc result in
 trace_cma_alloc_finish

On Fri, 16 Dec 2022 19:47:59 +0800
Wenchao Hao <haowenchao@...wei.com> wrote:

> On 2022/12/8 22:21, Wenchao Hao wrote:
> > The result of allocation is not printed in trace_cma_alloc_finish
> > now, while it's important to do it so we can set filters to catch
> > specific error on allocation or trigger some operations on specific
> > error.
> > 
> > Although we have printed the result in log, but the log is
> > conditional and could not be filtered by tracing event.
> > 
> > What's more, it introduce little overhead to print this result.
> > The result of allocation is named as errorno in trace.
> > 
> > Signed-off-by: Wenchao Hao <haowenchao@...wei.com>
> > ---

> 
> pinging


>From a tracing point of view, I see nothing wrong with it.

Reviewed-by: Steven Rostedt (Google) <rostedt@...dmis.org>

But I believe Andrew needs to take it.

-- Steve