| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <20221216115910.369093-2-tmricht@linux.ibm.com>
Date: Fri, 16 Dec 2022 12:59:10 +0100
From: Thomas Richter <tmricht@...ux.ibm.com>
To: linux-kernel@...r.kernel.org, linux-perf-users@...r.kernel.org,
acme@...nel.org, gor@...ux.ibm.com, sandipan.das@....com,
sumanthk@...ux.ibm.com
Cc: svens@...ux.ibm.com, hca@...ux.ibm.com,
Thomas Richter <tmricht@...ux.ibm.com>
Subject: [PATCH 2/2 v2] perf/test: Fix test case 89 for x86
perf test '89: probe libc's inet_pton & backtrace it with ping'
fails on x86. Debugging revealed a changed stack trace for the
ping command using probes:
ping 35729 [002] 8006.365063: probe_libc:inet_pton: (3ff9603e7c0)
12be50 __GI___inet_pton+0x0 (/usr/lib64/libc.so.6)
4fca main+0x139b (/usr/bin/ping)
The line getaddrinfo.... in the call stack is gone.
It was introduced with glibc version 2.36.8 released
with Fedora 37.
To make the test case more robust to glibc changes resulting in changed
call stack, redesign the test completely.
Read the output lines from the perf probe of the ping command.
Create an array of expected patterns. Each array entry specifies a
pattern that may appear in the perf probe output.
Check that each probe output line is matched in the expected
patterns array. If there is no match it is an error.
However not every pattern in the expected pattern array must be hit
as there may be redundant entries.
This scheme does not test the sequence of the call stack but the
patterns itself are long and complicated enough.
Output before on x86
# ./perf test 89
89: probe libc's inet_pton & backtrace it with ping : FAILED!
#
Output after on x86
# ./perf test 89
89: probe libc's inet_pton & backtrace it with ping : Ok
#
Signed-off-by: Thomas Richter <tmricht@...ux.ibm.com>
---
.../shell/record+probe_libc_inet_pton.sh | 71 ++++++++++++++-----
1 file changed, 52 insertions(+), 19 deletions(-)
diff --git a/tools/perf/tests/shell/record+probe_libc_inet_pton.sh b/tools/perf/tests/shell/record+probe_libc_inet_pton.sh
index 0f01c62cbee9..4edb2a1ce06b 100755
--- a/tools/perf/tests/shell/record+probe_libc_inet_pton.sh
+++ b/tools/perf/tests/shell/record+probe_libc_inet_pton.sh
@@ -30,28 +30,35 @@ add_libc_inet_pton_event() {
trace_libc_inet_pton_backtrace() {
- expected=`mktemp -u /tmp/expected.XXX`
+ declare -a expected
+ local -i idx=0
- echo "ping[][0-9 \.:]+$event_name: \([[:xdigit:]]+\)" > $expected
- echo ".*inet_pton\+0x[[:xdigit:]]+[[:space:]]\($libc|inlined\)$" >> $expected
+ expected[0]='ping[][0-9 \.:]+'"$event_name"': \([[:xdigit:]]+\)'
+ expected[1]='.*inet_pton\+0x[[:xdigit:]]+[[:space:]]\('"$libc"'|inlined\)$'
case "$(uname -m)" in
s390x)
eventattr='call-graph=dwarf,max-stack=4'
- echo "text_to_binary_address.*\+0x[[:xdigit:]]+[[:space:]]\($libc|inlined\)$" >> $expected
- echo "gaih_inet.*\+0x[[:xdigit:]]+[[:space:]]\($libc|inlined\)$" >> $expected
- echo "(__GI_)?getaddrinfo\+0x[[:xdigit:]]+[[:space:]]\($libc|inlined\)$" >> $expected
- echo "main\+0x[[:xdigit:]]+[[:space:]]\(.*/bin/ping.*\)$" >> $expected
+ expected[2]='text_to_binary_address.*\+0x[[:xdigit:]]+[[:space:]]\($libc|inlined\)$'
+ expected[3]='gaih_inet.*\+0x[[:xdigit:]]+[[:space:]]\('"$libc"'|inlined\)$'
+ expected[4]='(__GI_)?getaddrinfo\+0x[[:xdigit:]]+[[:space:]]\('"$libc"'|inlined\)$'
+ expected[5]='main\+0x[[:xdigit:]]+[[:space:]]\(.*/bin/ping.*\)$'
;;
ppc64|ppc64le)
eventattr='max-stack=4'
- echo "gaih_inet.*\+0x[[:xdigit:]]+[[:space:]]\($libc\)$" >> $expected
- echo "getaddrinfo\+0x[[:xdigit:]]+[[:space:]]\($libc\)$" >> $expected
- echo ".*(\+0x[[:xdigit:]]+|\[unknown\])[[:space:]]\(.*/bin/ping.*\)$" >> $expected
+ expected[2]='gaih_inet.*\+0x[[:xdigit:]]+[[:space:]]\('"$libc"'\)$'
+ expected[3]='getaddrinfo\+0x[[:xdigit:]]+[[:space:]]\('"$libc"'\)$'
+ # Line valid with glibc 2.35.x with fedora 36
+ expected[4]='.*(\+0x[[:xdigit:]]+|\[unknown\])[[:space:]]\(.*/bin/ping.*\)$'
+ # New line introduced with glibc 2.36.x with fedora 37, replaces previous line
+ expected[5]='[[:xdigit:]]+[[:space:]](\[unknown\]|main)\+0x[[:xdigit:]]+.*\(.*/bin/ping.*\)$'
;;
*)
eventattr='max-stack=3'
- echo "getaddrinfo\+0x[[:xdigit:]]+[[:space:]]\($libc\)$" >> $expected
- echo ".*(\+0x[[:xdigit:]]+|\[unknown\])[[:space:]]\(.*/bin/ping.*\)$" >> $expected
+ expected[2]='getaddrinfo\+0x[[:xdigit:]]+[[:space:]]\('"$libc"'\)$'
+ # Line valid with glibc 2.35.x with fedora 36
+ expected[3]='.*(\+0x[[:xdigit:]]+|\[unknown\])[[:space:]]\(.*/bin/ping.*\)$'
+ # New line introduced with glibc 2.36.x with fedora 37, replaces previous line
+ expected[4]='[[:xdigit:]]+[[:space:]](\[unknown\]|main)\+0x[[:xdigit:]]+.*\(.*/bin/ping.*\)$'
;;
esac
@@ -60,16 +67,42 @@ trace_libc_inet_pton_backtrace() {
perf record -e $event_name/$eventattr/ -o $perf_data ping -6 -c 1 ::1 > /dev/null 2>&1
perf script -i $perf_data > $perf_script
+ # To make the call stack checking more robust to changes in the glibc
+ # just check that each probe output line appears in the expected
+ # patterns array.
+ # This scheme does not check the sequence as before but tests
+ # that every line in the call stack is expected. Considering the
+ # long patterns this should be save too.
+ declare -a linehit linein
exec 3<$perf_script
- exec 4<$expected
- while read line <&3 && read -r pattern <&4; do
- [ -z "$pattern" ] && break
- echo $line
- echo "$line" | egrep -q "$pattern"
- if [ $? -ne 0 ] ; then
- printf "FAIL: expected backtrace entry \"%s\" got \"%s\"\n" "$pattern" "$line"
+
+ # Number of input lines to check, take value from max-stack attribute
+ lines_to_check="${eventattr##*=}"
+ while read line <&3; do
+ [ "$idx" -ge "$lines_to_check" ] && break
+ [ -z "$line" ] && break
+
+ for pattern in "${expected[@]}"
+ do
+ # echo PATTERN "$pattern"
+ linehit[$idx]=0
+ echo "$line" | egrep -q "$pattern"
+ [ $? -eq 0 ] && { linehit[$idx]=1; break; }
+ done
+ linein[$idx]="$line"
+ echo HIT "${linehit[$idx]}" LINE "'"$line"'"
+ ((++idx))
+ done
+ # Now check that every input line was expected
+ idx=0
+ for hit in "${linehit[@]}"
+ do
+ if [ "$hit" -eq 0 ]
+ then
+ printf "FAIL: missing backtrace entry for line \"%s\"" "${linein[$idx]}"
return 1
fi
+ ((++idx))
done
# If any statements are executed from this point onwards,
--
2.38.1
Powered by blists - more mailing lists